write() should not exit early on TX FIFO full

Author: 2bndy5

circuitpython_nrf24l01/rf24.py

@@ -837,12 +837,10 @@ def write(
         elif not buf or len(buf) > 32:
             raise ValueError("buffer must have a length in range [1, 32]")
         self.clear_status_flags()
-        if self._in[0] & 1:
-            return False
         self._reg_write_bytes(0xA0 | (bool(ask_no_ack) << 4), buf)
         if not write_only:
             self._ce_pin.value = True
-        return True
+        return bool(self._in[0] & 1)
 
     def flush_rx(self):
         """Flush all 3 levels of the RX FIFO."""

examples/nrf24l01_stream_test.py

@@ -112,17 +112,14 @@ def master_fifo(count=1, size=32):
         for buf in payloads:
             while not nrf.write(buf) and failures <= 99:
                 # NOTE write() returns False if TX FIFO is already full
-                while nrf.update() and nrf.tx_full:
-                    # just wait while TX FIFO is full or error occurs
-                    if nrf.irq_df:
-                        # reception failed; TX FIFO is locked
-                        failures += 1  # increment manual retries
-                        # we need to reset the irq_rf flag and the radio's CE pin
-                        nrf.ce_pin = False  # fall back to Standby-I mode
-                        # NOTE next call to nrf.write() will
-                        # nrf.clear_status_flags()  # clear the irq_df flag
-                        # nrf.ce_pin = True  # restart transmissions
-                        break  # exit `while tx_full` and call write()
+                if nrf.irq_df:
+                    # reception failed; TX FIFO is locked
+                    failures += 1  # increment manual retries
+                    # we need to reset the irq_rf flag and the radio's CE pin
+                    nrf.ce_pin = False  # fall back to Standby-I mode
+                    # NOTE next call to nrf.write() will
+                    # nrf.clear_status_flags()  # clear the irq_df flag
+                    # nrf.ce_pin = True  # restart transmissions
             if failures > 99:
                 # exit early because RX side seems absent
                 nrf.flush_tx()  # discard all payloads in TX FIFO