refactor: ruff checkテスト周り

Author: Yuya-Ozawa

tests/conftest.py

@@ -1,6 +1,8 @@
-import pytest
-from unittest.mock import Mock, patch
 import os
+from unittest.mock import Mock, patch
+
+import pytest
+
 from src.config import SharePointConfig
 
 

tests/test_config.py

@@ -1,6 +1,7 @@
-import pytest
-from unittest.mock import patch, mock_open
 import os
+from unittest.mock import patch
+
+import pytest
 
 from src.config import SharePointConfig
 
@@ -25,8 +26,14 @@ def test_missing_required_env_vars(self):
             validation_errors = config.validate()
 
             assert len(validation_errors) > 0
-            assert any("SHAREPOINT_TENANT_ID is required" in error for error in validation_errors)
-            assert any("SHAREPOINT_CLIENT_ID is required" in error for error in validation_errors)
+            assert any(
+                "SHAREPOINT_TENANT_ID is required" in error
+                for error in validation_errors
+            )
+            assert any(
+                "SHAREPOINT_CLIENT_ID is required" in error
+                for error in validation_errors
+            )
 
     def test_certificate_text_priority_over_file(self):
         """証明書テキストがファイルパスより優先されることのテスト"""
@@ -82,7 +89,9 @@ def test_default_values(self):
 
             assert config.default_max_results == 20
             assert "pdf" in config.allowed_file_extensions
-            assert "Search for documents in SharePoint" in config.search_tool_description
+            assert (
+                "Search for documents in SharePoint" in config.search_tool_description
+            )
             assert "Download a file from SharePoint" in config.download_tool_description
 
     @pytest.mark.unit
@@ -119,16 +128,19 @@ def test_parse_onedrive_paths_basic(self):
             targets = config.parse_onedrive_paths()
 
             assert len(targets) == 2
-            
+
             # user1@company.com（フォルダー指定なし）
             assert targets[0]["email"] == "user1@company.com"
             assert targets[0]["folder_path"] == ""
             assert targets[0]["onedrive_path"] == "personal/user1_company_com"
-            
+
             # user2@company.com:/Documents/Projects
             assert targets[1]["email"] == "user2@company.com"
             assert targets[1]["folder_path"] == "/Documents/Projects"
-            assert targets[1]["onedrive_path"] == "personal/user2_company_com/Documents/Projects"
+            assert (
+                targets[1]["onedrive_path"]
+                == "personal/user2_company_com/Documents/Projects"
+            )
 
     def test_parse_onedrive_paths_empty(self):
         """OneDriveパス設定が空の場合のテスト"""
@@ -147,21 +159,23 @@ def test_parse_onedrive_paths_empty(self):
     def test_email_to_onedrive_path_conversion(self):
         """メールアドレスからOneDriveパスへの変換テスト"""
         config = SharePointConfig()
-        
+
         # 基本的な変換
         path = config._email_to_onedrive_path("user@company.com")
         assert path == "personal/user_company_com"
-        
+
         # フォルダーパス付き
         path = config._email_to_onedrive_path("user@company.com", "/Documents/Projects")
         assert path == "personal/user_company_com/Documents/Projects"
-        
+
         # 先頭スラッシュの除去
         path = config._email_to_onedrive_path("user@company.com", "Documents/Projects")
         assert path == "personal/user_company_com/Documents/Projects"
-        
+
         # onmicrosoft.com ドメイン
-        path = config._email_to_onedrive_path("admin@company.onmicrosoft.com", "/Documents")
+        path = config._email_to_onedrive_path(
+            "admin@company.onmicrosoft.com", "/Documents"
+        )
         assert path == "personal/admin_company_onmicrosoft_com/Documents"
 
     def test_include_onedrive_property(self):
@@ -359,7 +373,10 @@ def test_disable_multiple_tools(self):
         with patch.dict(os.environ, env_vars, clear=True):
             config = SharePointConfig()
 
-            assert config.disabled_tools == {"sharepoint_excel", "sharepoint_docs_download"}
+            assert config.disabled_tools == {
+                "sharepoint_excel",
+                "sharepoint_docs_download",
+            }
             assert config.is_tool_enabled("sharepoint_docs_search") is True
             assert config.is_tool_enabled("sharepoint_docs_download") is False
             assert config.is_tool_enabled("sharepoint_excel") is False
@@ -416,6 +433,9 @@ def test_whitespace_handling(self):
         with patch.dict(os.environ, env_vars, clear=True):
             config = SharePointConfig()
 
-            assert config.disabled_tools == {"sharepoint_excel", "sharepoint_docs_download"}
+            assert config.disabled_tools == {
+                "sharepoint_excel",
+                "sharepoint_docs_download",
+            }
             assert config.is_tool_enabled("sharepoint_excel") is False
             assert config.is_tool_enabled("sharepoint_docs_download") is False

tests/test_error_messages.py

@@ -1,8 +1,8 @@
 import zipfile
+from unittest.mock import Mock
 
 import pytest
 import requests
-from unittest.mock import Mock
 
 from src.error_messages import (
     ErrorCategory,
@@ -57,7 +57,10 @@ def test_http_error_404(self):
         result = handle_sharepoint_error(http_error, "search")
 
         assert "error" in str(result).lower()
-        assert "configuration" in str(result).lower() or "administrator" in str(result).lower()
+        assert (
+            "configuration" in str(result).lower()
+            or "administrator" in str(result).lower()
+        )
 
     @pytest.mark.unit
     def test_connection_error(self):
@@ -77,7 +80,10 @@ def test_timeout_error(self):
         result = handle_sharepoint_error(timeout_error, "search")
 
         assert "error" in str(result).lower()
-        assert "configuration" in str(result).lower() or "administrator" in str(result).lower()
+        assert (
+            "configuration" in str(result).lower()
+            or "administrator" in str(result).lower()
+        )
 
     @pytest.mark.unit
     def test_certificate_error(self):
@@ -87,7 +93,10 @@ def test_certificate_error(self):
         result = handle_sharepoint_error(cert_error, "search")
 
         assert "certificate" in str(result).lower()
-        assert "configured" in str(result).lower() or "configuration" in str(result).lower()
+        assert (
+            "configured" in str(result).lower()
+            or "configuration" in str(result).lower()
+        )
 
     @pytest.mark.unit
     def test_generic_error(self):
@@ -97,7 +106,10 @@ def test_generic_error(self):
         result = handle_sharepoint_error(generic_error, "search")
 
         assert "unexpected error" in str(result).lower()
-        assert "configuration" in str(result).lower() or "administrator" in str(result).lower()
+        assert (
+            "configuration" in str(result).lower()
+            or "administrator" in str(result).lower()
+        )
 
     @pytest.mark.unit
     def test_download_context_specific_message(self):
@@ -107,7 +119,10 @@ def test_download_context_specific_message(self):
         result = handle_sharepoint_error(generic_error, "download")
 
         assert "error" in str(result).lower()
-        assert "configuration" in str(result).lower() or "administrator" in str(result).lower()
+        assert (
+            "configuration" in str(result).lower()
+            or "administrator" in str(result).lower()
+        )
 
     @pytest.mark.unit
     def test_http_error_without_response(self):
@@ -117,7 +132,10 @@ def test_http_error_without_response(self):
         result = handle_sharepoint_error(http_error, "search")
 
         assert "error" in str(result).lower()
-        assert "configuration" in str(result).lower() or "administrator" in str(result).lower()
+        assert (
+            "configuration" in str(result).lower()
+            or "administrator" in str(result).lower()
+        )
 
 
 class TestExcelErrorClassification:
@@ -145,7 +163,9 @@ def test_excel_file_not_found_http_404(self):
     @pytest.mark.unit
     def test_excel_sheet_not_found(self):
         """シートが見つからないエラーの分類テスト"""
-        error = ValueError("Sheet 'NonExistent' not found. Available sheets: ['Sheet1']")
+        error = ValueError(
+            "Sheet 'NonExistent' not found. Available sheets: ['Sheet1']"
+        )
 
         result = handle_sharepoint_error(
             error,
@@ -208,4 +228,4 @@ def test_excel_context_preserves_file_path(self):
             excel_context={"file_path": file_path},
         )
 
-        assert file_path in str(result)
+        assert file_path in str(result)