Skip to content

Commit 5e8ba21

Browse files
k-ibarakiclaude
andcommitted
refactor: improve test clarity and prevent warning logs
レビューコメントに対応: - test_omit_null_dimensionsから不要な_create_test_excel()呼び出しを削除 - download_file.return_value = b""に簡略化(load_workbookがモックされているため) - mock_sheet.sheet_view = Mock(pane=None)を追加して、_get_frozen_panes()での警告ログを防止 Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
1 parent 35e8a99 commit 5e8ba21

1 file changed

Lines changed: 4 additions & 4 deletions

File tree

tests/test_sharepoint_excel.py

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1555,10 +1555,6 @@ def test_include_non_null_fields(self):
15551555

15561556
def test_omit_null_dimensions(self):
15571557
"""dimensions=nullが省略されること"""
1558-
# 通常のExcelを作成
1559-
excel_bytes = self._create_test_excel()
1560-
self.mock_download_client.download_file.return_value = excel_bytes
1561-
15621558
parser = SharePointExcelParser(self.mock_download_client)
15631559

15641560
# モックを使用してsheet.dimensionsをNoneに設定
@@ -1568,6 +1564,8 @@ def test_omit_null_dimensions(self):
15681564
mock_sheet.title = "EmptySheet"
15691565
mock_sheet.dimensions = None # dimensionsをNoneに設定
15701566
mock_sheet.freeze_panes = None # freeze_panesもNone
1567+
# sheet_viewを設定して_get_frozen_panes()での警告ログを防ぐ
1568+
mock_sheet.sheet_view = Mock(pane=None)
15711569
# merged_cellsはranges属性を持つオブジェクト
15721570
mock_merged_cells = Mock()
15731571
mock_merged_cells.ranges = []
@@ -1580,6 +1578,8 @@ def test_omit_null_dimensions(self):
15801578
mock_wb.close = Mock()
15811579
mock_load.return_value = mock_wb
15821580

1581+
# load_workbookがモックされているため、download_fileの戻り値は実際には使われない
1582+
self.mock_download_client.download_file.return_value = b""
15831583
result_json = parser.parse_to_json("/test/empty.xlsx")
15841584

15851585
result = json.loads(result_json)

0 commit comments

Comments
 (0)