Commit bea5940
style: address AI review feedback (import and docstring)
## 修正内容
### 1. import文の整理(tests/test_sharepoint_excel.py)
- `from unittest.mock import patch` をメソッド内からファイル先頭に移動
- PEP 8に準拠:`from unittest.mock import Mock, patch` に統合
### 2. docstringの改善(src/sharepoint_excel.py)
- `_build_merged_cell_cache`メソッドのdocstringを拡充
- `effective_cell_range`パラメータの説明を追加:
- 正規化・拡張済みのセル範囲であることを明記
- 形式("A1:D10")と挙動(Noneの場合)を説明
- 返り値の説明を追加
## 背景
PR #40 のAIレビュー指摘(Gemini, Copilot)に対応:
- import文の位置がPEP 8に準拠していない
- `effective_cell_range`パラメータの意味が不明確
これらは軽微な問題だが、コードの可読性と保守性を向上させるため対応。
Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>1 parent 8a4f699 commit bea5940
2 files changed
Lines changed: 9 additions & 3 deletions
File tree
- src
- tests
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
439 | 439 | | |
440 | 440 | | |
441 | 441 | | |
| 442 | + | |
| 443 | + | |
| 444 | + | |
| 445 | + | |
| 446 | + | |
| 447 | + | |
| 448 | + | |
| 449 | + | |
442 | 450 | | |
443 | 451 | | |
444 | 452 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1 | 1 | | |
2 | 2 | | |
3 | 3 | | |
4 | | - | |
| 4 | + | |
5 | 5 | | |
6 | 6 | | |
7 | 7 | | |
| |||
849 | 849 | | |
850 | 850 | | |
851 | 851 | | |
852 | | - | |
853 | | - | |
854 | 852 | | |
855 | 853 | | |
856 | 854 | | |
| |||
0 commit comments