Downgrade three rules after discussion with team (#16)

Author: neoscie

.github/workflows/cd-production.yml

@@ -9,8 +9,7 @@ env:
   ARTIFACTS_FEED_URL: https://api.nuget.org/v3/index.json
 
 jobs:
-  publish:
-    name: build, pack & publish
+  pack-and-publish:
     runs-on: ubuntu-latest
     steps:    
       - name: Checkout
@@ -35,3 +34,12 @@ jobs:
         run: dotnet nuget push --skip-duplicate -s $ARTIFACTS_FEED_URL -k $NUGET_AUTH_TOKEN **/*.nupkg
         env:
           NUGET_AUTH_TOKEN: ${{ secrets.NUGET_API_KEY_NEOLUTION }}
+        
+  notify:
+    needs: [pack-and-publish]
+    runs-on: ubuntu-latest
+    steps:
+      - uses: neolution-ch/action-release-notifier@v1
+        with:
+          slack-token: ${{ secrets.SLACK_RELEASE_NOTIFIER_TOKEN }}
+          slack-channel-ids: "CD34NHYN6"

.github/workflows/ci.yml

@@ -8,8 +8,7 @@ on:
   workflow_dispatch:
 
 jobs:
-  publish:
-    name: build & pack
+  pack:
     runs-on: ubuntu-latest
     steps:    
       - name: Checkout

CHANGELOG.md

@@ -7,11 +7,21 @@ and adheres to a project-specific [Versioning](/README.md).
 
 ## [Unreleased]
 
+### Added
+
+- Notification for Slack channel upon new releases
+
+### Changed
+
+- Changed "S3242: Method parameters should be declared with base types" to `suggestion`
+- Changed "S3257: Declarations and initializations should be as concise as possible" to `suggestion`
+- Changed "S3267: Loops should be simplified with "LINQ" expressions" to `suggestion`
+
 ## [3.0.0] - 2023-06-28
 
 ### Changed
 
-- Stopped changing all rules to error first and instead use the default rulesets of the Analyzers as the base ru
+- Stopped changing all rules to error first and instead use the default rulesets of the Analyzers as the base rules
 - Migrate from \*.ruleset files to \*.globalconfig files
 - Migrate from \*.targets to \*. props files
 - Simplified and decluttered README file

build/Neolution.Tests.globalconfig

@@ -266,6 +266,18 @@ dotnet_diagnostic.CA2007.severity = warning
 ; Exceptions can be configured in stylecop.json
 dotnet_diagnostic.SA1412.severity = warning
 
+# S3242: Method parameters should be declared with base types
+; False positive with IEnumerable<T> that could lead to multiple enumerations. This should be only applied on Developers discretion.
+dotnet_diagnostic.S3242.severity = suggestion
+
+# S3257: Declarations and initializations should be as concise as possible
+; In some cases developers may prefer the verbosity of a unused parameter over the easier readability of a discard.
+dotnet_diagnostic.S3257.severity = suggestion
+
+# S3267: Loops should be simplified with "LINQ" expressions
+; This can be an annoying rule in cases where it does not really improve readability or even worsens it.
+dotnet_diagnostic.S3267.severity = suggestion
+
 # S107: Methods should not have too many parameters
 dotnet_diagnostic.S107.severity = warning
 
@@ -443,18 +455,12 @@ dotnet_diagnostic.S3234.severity = error
 # S3240: The simplest possible condition syntax should be used
 dotnet_diagnostic.S3240.severity = warning
 
-# S3242: Method parameters should be declared with base types
-dotnet_diagnostic.S3242.severity = warning
-
 # S3253: Constructor and destructor declarations should not be redundant
 dotnet_diagnostic.S3253.severity = warning
 
 # S3254: Default parameter values should not be passed as arguments
 dotnet_diagnostic.S3254.severity = warning
 
-# S3257: Declarations and initializations should be as concise as possible
-dotnet_diagnostic.S3257.severity = warning
-
 # S3353: Unchanged local variables should be "const"
 dotnet_diagnostic.S3353.severity = warning
 

build/Neolution.globalconfig

@@ -1,4 +1,4 @@
-# Top level entry required to mark this as a global AnalyzerConfig file
+# Top level entry required to mark this as a global AnalyzerConfig file
 # NOTE: Do not create section headers for configuration entries
 is_global = true
 
@@ -226,6 +226,18 @@ dotnet_diagnostic.CA2007.severity = warning
 ; Exceptions can be configured in stylecop.json
 dotnet_diagnostic.SA1412.severity = warning
 
+# S3242: Method parameters should be declared with base types
+; False positive with IEnumerable<T> that could lead to multiple enumerations. This should be only applied on Developers discretion.
+dotnet_diagnostic.S3242.severity = suggestion
+
+# S3257: Declarations and initializations should be as concise as possible
+; In some cases developers may prefer the verbosity of a unused parameter over the easier readability of a discard.
+dotnet_diagnostic.S3257.severity = suggestion
+
+# S3267: Loops should be simplified with "LINQ" expressions
+; This can be an annoying rule in cases where it does not really improve readability or even worsens it.
+dotnet_diagnostic.S3267.severity = suggestion
+
 # S107: Methods should not have too many parameters
 dotnet_diagnostic.S107.severity = warning
 
@@ -403,18 +415,12 @@ dotnet_diagnostic.S3234.severity = error
 # S3240: The simplest possible condition syntax should be used
 dotnet_diagnostic.S3240.severity = warning
 
-# S3242: Method parameters should be declared with base types
-dotnet_diagnostic.S3242.severity = warning
-
 # S3253: Constructor and destructor declarations should not be redundant
 dotnet_diagnostic.S3253.severity = warning
 
 # S3254: Default parameter values should not be passed as arguments
 dotnet_diagnostic.S3254.severity = warning
 
-# S3257: Declarations and initializations should be as concise as possible
-dotnet_diagnostic.S3257.severity = warning
-
 # S3353: Unchanged local variables should be "const"
 dotnet_diagnostic.S3353.severity = warning