Neolution CodeAnalysis V3 (#14)

* Update README.md
* Add changelog
* Fix CI and CD
* Update rules
* Add previously added SonarSource rules
* Add rules from Microsoft .NET Minimum Ruleset
* Group same rules together for a better overview
* Fix Tests ruleset
---------

Co-authored-by: GitHub Release Bot <release-bot@neolution.ch>
Co-authored-by: neotrow <92933708+neotrow@users.noreply.github.com>

Author: 3 people

.github/workflows/cd-production.yml

@@ -20,7 +20,7 @@ jobs:
         run: echo NUGET_VERSION=${GITHUB_REF#refs/tags/v} >> $GITHUB_ENV
 
       - name: Replace version number in nuspec files
-        run: 'sed -i -e "s/{{NuGetVersion}}/$NUGET_VERSION/g" *.nuspec **/*.targets'
+        run: 'sed -i -e "s/{{NuGetVersion}}/$NUGET_VERSION/g" *.nuspec'
 
       - name: Setup NuGet.exe for use with actions
         uses: NuGet/setup-nuget@v1.2.0
@@ -32,6 +32,6 @@ jobs:
         run: nuget pack Neolution.CodeAnalysis.TestsRuleset.nuspec
 
       - name: Push all packages to Nuget.org
-        run: dotnet nuget push --skip-duplicate -s $ARTIFACTS_FEED_URL -k $NUGET_AUTH_TOKEN  **/*.nupkg
+        run: dotnet nuget push --skip-duplicate -s $ARTIFACTS_FEED_URL -k $NUGET_AUTH_TOKEN **/*.nupkg
         env:
           NUGET_AUTH_TOKEN: ${{ secrets.NUGET_API_KEY_NEOLUTION }}

.github/workflows/ci.yml

@@ -19,7 +19,7 @@ jobs:
         run: echo NUGET_VERSION=0.$(date '+%Y.%m')-ci.$(date '+%d%H%M%S') >> $GITHUB_ENV
 
       - name: Replace version number in nuspec files
-        run: 'sed -i -e "s/{{NuGetVersion}}/$NUGET_VERSION/g" *.nuspec **/*.targets'
+        run: 'sed -i -e "s/{{NuGetVersion}}/$NUGET_VERSION/g" *.nuspec'
 
       - name: Setup NuGet.exe for use with actions
         uses: NuGet/setup-nuget@v1.2.0

.github/workflows/create-release.yml

@@ -7,7 +7,7 @@ on:
         type: choice
         description: Semantic Version Type
         options:
-          - no-version-update
+          - automatic
           - patch
           - minor
           - major
@@ -50,7 +50,7 @@ jobs:
         run: |
           params=()
 
-          if [[ ${{ github.event.inputs.version_type }} != "no-version-update" ]]; then
+          if [[ ${{ github.event.inputs.version_type }} != "automatic" ]]; then
               params+=(${{ github.event.inputs.version_type }})
           fi
 
@@ -62,6 +62,7 @@ jobs:
 
           params+=(--ci)
 
-          release-it -y "${params[@]}"
+          echo "command: release-it ${params[@]}"
+          release-it "${params[@]}"
         env:
           GITHUB_TOKEN: ${{ steps.generate-token.outputs.token }}

.gitignore

@@ -0,0 +1,4 @@
+
+*.nupkg
+
+*.exe

.release-it.json

@@ -14,7 +14,7 @@
       "filename": "CHANGELOG.md",
       "addVersionUrl": true,
       "addUnreleased": true,
-      "strictLatest": false
+      "strictLatest": true
     }
   },
   "hooks": {

CHANGELOG.md

@@ -7,6 +7,17 @@ and adheres to a project-specific [Versioning](/README.md).
 
 ## [Unreleased]
 
+### Changed
+
+- Stopped changing all rules to error first and instead use the default rulesets of the Analyzers as the base ru
+- Migrate from \*.ruleset files to \*.globalconfig files
+- Migrate from \*.targets to \*. props files
+- Simplified and decluttered README file
+
+### Removed
+
+- Removed FxCop Analyzer because it is now bundled with .NET SDK
+
 ## [2.7.1] - 2023-06-14
 
 ### Added

GitVersion.yml

@@ -12,18 +12,14 @@
     <requireLicenseAcceptance>false</requireLicenseAcceptance>
     <developmentDependency>true</developmentDependency>
     <dependencies>
-      <dependency id="StyleCop.Analyzers" version="1.1.118" />
-      <dependency id="Microsoft.CodeAnalysis.FxCopAnalyzers" version="3.3.1" />
+      <dependency id="StyleCop.Analyzers" version="1.2.0-beta.435" />
       <dependency id="SonarAnalyzer.CSharp" version="8.52.0.60960" />
     </dependencies>
   </metadata>
   <files>
-    <file src="build\Neolution.CodeAnalysis.TestsRuleset.targets" target="build\Neolution.CodeAnalysis.TestsRuleset.targets" />
-    <file src="Neolution.Debug.ruleset" target="Neolution.Debug.ruleset" />
-    <file src="Neolution.Release.ruleset" target="Neolution.Release.ruleset" />
-    <file src="Neolution.Tests.Debug.ruleset" target="Neolution.Tests.Debug.ruleset" />
-    <file src="Neolution.Tests.Release.ruleset" target="Neolution.Tests.Release.ruleset" />
-    <file src="stylecop.json" target="stylecop.json" />
+    <file src="build\Neolution.CodeAnalysis.TestsRuleset.props" target="build\Neolution.CodeAnalysis.TestsRuleset.props" />
+    <file src="build\Neolution.Tests.globalconfig" target="build\Neolution.Tests.globalconfig" />
+    <file src="build\stylecop.json" target="build\stylecop.json" />
     <file src="README.md" target="docs\" />
   </files>
-</package>
+</package>

Neolution.CodeAnalysis.TestsRuleset.nuspec

@@ -12,16 +12,14 @@
     <requireLicenseAcceptance>false</requireLicenseAcceptance>
     <developmentDependency>true</developmentDependency>
     <dependencies>
-      <dependency id="StyleCop.Analyzers" version="1.1.118" />
-      <dependency id="Microsoft.CodeAnalysis.FxCopAnalyzers" version="3.3.1" />
+      <dependency id="StyleCop.Analyzers" version="1.2.0-beta.435" />
       <dependency id="SonarAnalyzer.CSharp" version="8.52.0.60960" />
     </dependencies>
   </metadata>
   <files>
-    <file src="build\Neolution.CodeAnalysis.targets" target="build\Neolution.CodeAnalysis.targets" />
-    <file src="Neolution.Debug.ruleset" target="Neolution.Debug.ruleset" />
-    <file src="Neolution.Release.ruleset" target="Neolution.Release.ruleset" />
-    <file src="stylecop.json" target="stylecop.json" />
+    <file src="build\Neolution.CodeAnalysis.props" target="build\Neolution.CodeAnalysis.props" />
+    <file src="build\Neolution.globalconfig" target="build\Neolution.globalconfig" />
+    <file src="build\stylecop.json" target="build\stylecop.json" />
     <file src="README.md" target="docs\" />
   </files>
-</package>
+</package>