Skip to content

Commit abb7821

Browse files
committed
Disables SA1615 and S3900 in test rulesets
1 parent 2bd3ec1 commit abb7821

3 files changed

Lines changed: 16 additions & 2 deletions

File tree

CHANGELOG.md

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,11 @@ and adheres to a project-specific [Versioning](/README.md).
77

88
## [Unreleased]
99

10+
### Removed
11+
12+
- [Tests ruleset] SA1615: Element return value should be documented
13+
- [Tests ruleset] S3900: Validate arguments of public methods
14+
1015
## [3.2.1] - 2024-11-18
1116

1217
### Fixed

Neolution.CodeAnalysis.nuspec

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,12 +5,13 @@
55
<version>{{NuGetVersion}}</version>
66
<title>Neolution Code Analysis</title>
77
<authors>Neolution AG</authors>
8-
<description>Configures Code Analysis for Neolution Projects</description>
8+
<description>Configures Code Analysis for Neolution Projects.</description>
99
<projectUrl>https://github.com/neolution-ch/Neolution.CodeAnalysis</projectUrl>
1010
<readme>docs\README.md</readme>
1111
<license type="expression">MIT</license>
1212
<requireLicenseAcceptance>false</requireLicenseAcceptance>
1313
<developmentDependency>true</developmentDependency>
14+
<releaseNotes>See CHANGELOG.md for release notes and version history.</releaseNotes>
1415
<dependencies>
1516
<dependency id="StyleCop.Analyzers.Unstable" version="1.2.0.556" />
1617
<dependency id="SonarAnalyzer.CSharp" version="9.20.0.85982" />

build/Neolution.CodeAnalysis.TestsRuleset.globalconfig

Lines changed: 9 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -43,4 +43,12 @@ dotnet_diagnostic.S4581.severity = suggestion
4343

4444
# S4144: Methods should not have identical implementations
4545
; When using parameterised tests it can make sense to have different test methods with different parametrization but using the same implementation.
46-
dotnet_diagnostic.S4144.severity = none
46+
dotnet_diagnostic.S4144.severity = none
47+
48+
# SA1615: Element return value should be documented
49+
; This adds no value in tests
50+
dotnet_diagnostic.SA1615.severity = none
51+
52+
# Validate arguments of public methods
53+
; Generally adds limited value and can often be counterproductive in test projects
54+
dotnet_diagnostic.S3900.severity = none

0 commit comments

Comments
 (0)