Skip to content

Commit c01d149

Browse files
committed
Merge branch 'main' into feature/v3.1
2 parents 279be99 + 9933359 commit c01d149

5 files changed

Lines changed: 50 additions & 10 deletions

File tree

.github/workflows/cd-production.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -42,4 +42,4 @@ jobs:
4242
- uses: neolution-ch/action-release-notifier@v1
4343
with:
4444
slack-token: ${{ secrets.SLACK_RELEASE_NOTIFIER_TOKEN }}
45-
slack-channel-ids: "CD34NHYN6"
45+
slack-channel-ids: ${{ vars.SLACK_CHANNEL_ID_RELEASE_ANNOUNCEMENTS }}

CHANGELOG.md

Lines changed: 39 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -37,6 +37,40 @@ and adheres to a project-specific [Versioning](/README.md).
3737

3838
- SA1518: Use line endings correctly at end of file
3939

40+
## [3.0.5] - 2023-09-28
41+
42+
### Fixed
43+
44+
- Misplaced `Configuration` element in `*.props` file in previous release, causing all projects to fail build
45+
46+
## [3.0.4] - 2023-09-27
47+
48+
### Fixed
49+
50+
- If build configuration is not passed explicitly, it should be like passing `Debug`
51+
52+
### Changed
53+
54+
- The XML documentation can be generated in all build configurations, there is no need to restrict it.
55+
56+
## [3.0.3] - 2023-07-20
57+
58+
### Fixed
59+
60+
- In some cases the XML documentation file had a bad file name when the `$(AssemblyName)` variable was not set during the build process
61+
62+
## [3.0.2] - 2023-07-17
63+
64+
### Fixed
65+
66+
- Fixed TestsRuleset so the tests-specific rules override the regular rules and not the other way around
67+
68+
### Removed
69+
70+
- CA2253: Named placeholders should not be numeric values
71+
- CA2254: Template should be a static expression
72+
- SA1518: Use line endings correctly at end of file (removed in favor of S113)
73+
4074
## [3.0.1] - 2023-07-12
4175

4276
### Added
@@ -68,7 +102,11 @@ and adheres to a project-specific [Versioning](/README.md).
68102

69103
- Changelog
70104

71-
[unreleased]: https://github.com/neolution-ch/Neolution.CodeAnalysis/compare/v3.0.1...HEAD
105+
[unreleased]: https://github.com/neolution-ch/Neolution.CodeAnalysis/compare/v3.0.5...HEAD
106+
[3.0.5]: https://github.com/neolution-ch/Neolution.CodeAnalysis/compare/v3.0.4...v3.0.5
107+
[3.0.4]: https://github.com/neolution-ch/Neolution.CodeAnalysis/compare/v3.0.3...v3.0.4
108+
[3.0.3]: https://github.com/neolution-ch/Neolution.CodeAnalysis/compare/v3.0.2...v3.0.3
109+
[3.0.2]: https://github.com/neolution-ch/Neolution.CodeAnalysis/compare/v3.0.1...v3.0.2
72110
[3.0.1]: https://github.com/neolution-ch/Neolution.CodeAnalysis/compare/v3.0.0...v3.0.1
73111
[3.0.0]: https://github.com/neolution-ch/Neolution.CodeAnalysis/compare/v2.7.1...v3.0.0
74112
[2.7.1]: https://github.com/neolution-ch/Neolution.CodeAnalysis/compare/v2.7.0...v2.7.1

build/Neolution.CodeAnalysis.TestsRuleset.props

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,12 @@
11
<?xml version="1.0" encoding="utf-8"?>
22
<Project ToolsVersion="14.0" xmlns="http://schemas.microsoft.com/developer/msbuild/2003">
33

4+
<PropertyGroup>
5+
<Configuration Condition="'$(Configuration)' == ''">Debug</Configuration>
6+
<GenerateDocumentationFile>true</GenerateDocumentationFile>
7+
</PropertyGroup>
8+
49
<PropertyGroup Condition="'$(Configuration)' != 'Debug'">
5-
<DocumentationFile>bin/$(Configuration)/$(TargetFramework)/$(AssemblyName).xml</DocumentationFile>
610
<TreatWarningsAsErrors>true</TreatWarningsAsErrors>
711
</PropertyGroup>
812
<PropertyGroup Condition="'$(Configuration)' == 'Debug'">

build/Neolution.CodeAnalysis.globalconfig

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -743,9 +743,3 @@ dotnet_diagnostic.CA2250.severity = warning
743743

744744
# CA2252: This API requires opting into preview features
745745
dotnet_diagnostic.CA2252.severity = warning
746-
747-
# CA2253: Named placeholders should not be numeric values
748-
dotnet_diagnostic.CA2253.severity = warning
749-
750-
# CA2254: Template should be a static expression
751-
dotnet_diagnostic.CA2254.severity = warning

build/Neolution.CodeAnalysis.props

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,12 @@
11
<?xml version="1.0" encoding="utf-8"?>
22
<Project ToolsVersion="14.0" xmlns="http://schemas.microsoft.com/developer/msbuild/2003">
33

4+
<PropertyGroup>
5+
<Configuration Condition="'$(Configuration)' == ''">Debug</Configuration>
6+
<GenerateDocumentationFile>true</GenerateDocumentationFile>
7+
</PropertyGroup>
8+
49
<PropertyGroup Condition="'$(Configuration)' != 'Debug'">
5-
<DocumentationFile>bin/$(Configuration)/$(TargetFramework)/$(AssemblyName).xml</DocumentationFile>
610
<TreatWarningsAsErrors>true</TreatWarningsAsErrors>
711
</PropertyGroup>
812
<PropertyGroup Condition="'$(Configuration)' == 'Debug'">

0 commit comments

Comments
 (0)