Skip to content

Commit ef5c729

Browse files
authored
Fix misplaced Configuration element in *.props file (#22)
* Release notifications should be publish to organization default channel
1 parent 91b5f28 commit ef5c729

4 files changed

Lines changed: 6 additions & 6 deletions

File tree

.github/workflows/cd-production.yml

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -42,5 +42,4 @@ jobs:
4242
- uses: neolution-ch/action-release-notifier@v1
4343
with:
4444
slack-token: ${{ secrets.SLACK_RELEASE_NOTIFIER_TOKEN }}
45-
# tech-announcements channel
46-
slack-channel-ids: "C05DR8P010A"
45+
slack-channel-ids: ${{ vars.SLACK_CHANNEL_ID_RELEASE_ANNOUNCEMENTS }}

CHANGELOG.md

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,9 @@ and adheres to a project-specific [Versioning](/README.md).
77

88
## [Unreleased]
99

10+
### Fixed
11+
- Misplaced `Configuration` element in `*.props` file in previous release, causing all projects to fail build
12+
1013
## [3.0.4] - 2023-09-27
1114

1215
### Fixed

build/Neolution.CodeAnalysis.TestsRuleset.props

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,8 @@
11
<?xml version="1.0" encoding="utf-8"?>
22
<Project ToolsVersion="14.0" xmlns="http://schemas.microsoft.com/developer/msbuild/2003">
33

4-
<Configuration Condition="'$(Configuration)' == ''">Debug</Configuration>
5-
64
<PropertyGroup>
5+
<Configuration Condition="'$(Configuration)' == ''">Debug</Configuration>
76
<GenerateDocumentationFile>true</GenerateDocumentationFile>
87
</PropertyGroup>
98

build/Neolution.CodeAnalysis.props

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,8 @@
11
<?xml version="1.0" encoding="utf-8"?>
22
<Project ToolsVersion="14.0" xmlns="http://schemas.microsoft.com/developer/msbuild/2003">
33

4-
<Configuration Condition="'$(Configuration)' == ''">Debug</Configuration>
5-
64
<PropertyGroup>
5+
<Configuration Condition="'$(Configuration)' == ''">Debug</Configuration>
76
<GenerateDocumentationFile>true</GenerateDocumentationFile>
87
</PropertyGroup>
98

0 commit comments

Comments
 (0)