Remove S4144: Methods should not have identical implementations from Tests ruleset (#28)

Author: neoscie

.github/workflows/ci.yml

@@ -15,7 +15,7 @@ jobs:
         uses: actions/checkout@v3
 
       - name: Determine version for NuGet package
-        run: echo NUGET_VERSION=0.$(date '+%Y.%m')-ci.$(date '+%d%H%M%S') >> $GITHUB_ENV
+        run: echo NUGET_VERSION=0.$(date '+%Y.%m')-ci$(date '+%d%H%M%S') >> $GITHUB_ENV
 
       - name: Replace version number in nuspec files
         run: 'sed -i -e "s/{{NuGetVersion}}/$NUGET_VERSION/g" *.nuspec'

CHANGELOG.md

@@ -7,6 +7,10 @@ and adheres to a project-specific [Versioning](/README.md).
 
 ## [Unreleased]
 
+### Removed
+
+- (Tests ruleset) S4144: Methods should not have identical implementations, because when using parameterised tests it can make sense to have different test methods with different parametrization but using the same implementation.
+
 ## [3.1.1] - 2024-09-20
 
 ### Changed

build/Neolution.CodeAnalysis.TestsRuleset.globalconfig

@@ -40,3 +40,7 @@ dotnet_diagnostic.S126.severity = none
 # S4581: "new Guid()" should not be used
 ; When creating mocks/substitutes this can be irrelevant, so it should not break the build
 dotnet_diagnostic.S4581.severity = suggestion
+
+# S4144: Methods should not have identical implementations
+; When using parameterised tests it can make sense to have different test methods with different parametrization but using the same implementation.
+dotnet_diagnostic.S4144.severity = none