Upgrades CodeAnalysis package to v3.2.2

- Bumps `Neolution.CodeAnalysis` from 2.6.1 to 3.2.2 across all projects
- Replaces blocking `Thread.Sleep` calls with async `Task.Delay` to comply with new analyzer rules
- Removes unused `using` directives flagged by updated ruleset
- Converts sync test method to `async Task` to support the async delay

Author: neoscie

Neolution.Extensions.Caching.Abstractions/Neolution.Extensions.Caching.Abstractions.csproj

@@ -8,7 +8,7 @@
 
   <ItemGroup>
     <PackageReference Include="Microsoft.Extensions.Options" Version="6.0.0" />
-    <PackageReference Include="Neolution.CodeAnalysis" Version="2.6.1">
+    <PackageReference Include="Neolution.CodeAnalysis" Version="3.2.2">
       <PrivateAssets>all</PrivateAssets>
       <IncludeAssets>runtime; build; native; contentfiles; analyzers; buildtransitive</IncludeAssets>
     </PackageReference>

Neolution.Extensions.Caching.Distributed/Neolution.Extensions.Caching.Distributed.csproj

@@ -10,7 +10,7 @@
     <PackageReference Include="Foundatio.MessagePack" Version="12.0.0" />
     <PackageReference Include="Microsoft.Extensions.Caching.Abstractions" Version="6.0.0" />
     <PackageReference Include="Microsoft.Extensions.Options" Version="6.0.0" />
-    <PackageReference Include="Neolution.CodeAnalysis" Version="2.6.1">
+    <PackageReference Include="Neolution.CodeAnalysis" Version="3.2.2">
       <PrivateAssets>all</PrivateAssets>
       <IncludeAssets>runtime; build; native; contentfiles; analyzers; buildtransitive</IncludeAssets>
     </PackageReference>

Neolution.Extensions.Caching.InMemory/Neolution.Extensions.Caching.InMemory.csproj

@@ -8,7 +8,7 @@
 
   <ItemGroup>
     <PackageReference Include="Microsoft.Extensions.Caching.Memory" Version="6.0.2" />
-    <PackageReference Include="Neolution.CodeAnalysis" Version="2.6.1">
+    <PackageReference Include="Neolution.CodeAnalysis" Version="3.2.2">
       <PrivateAssets>all</PrivateAssets>
       <IncludeAssets>runtime; build; native; contentfiles; analyzers; buildtransitive</IncludeAssets>
     </PackageReference>

Neolution.Extensions.Caching.RedisHybrid/Neolution.Extensions.Caching.RedisHybrid.csproj

@@ -10,7 +10,7 @@
     <PackageReference Include="Foundatio.MessagePack" Version="12.0.0" />
     <PackageReference Include="Foundatio.Redis" Version="12.0.0" />
     <PackageReference Include="Microsoft.Extensions.Options" Version="6.0.0" />
-    <PackageReference Include="Neolution.CodeAnalysis" Version="2.6.1">
+    <PackageReference Include="Neolution.CodeAnalysis" Version="3.2.2">
       <PrivateAssets>all</PrivateAssets>
       <IncludeAssets>runtime; build; native; contentfiles; analyzers; buildtransitive</IncludeAssets>
     </PackageReference>

Neolution.Extensions.Caching.UnitTests/CacheKeyVersioningTests.cs

@@ -3,8 +3,6 @@
     using System;
     using Microsoft.Extensions.DependencyInjection;
     using Neolution.Extensions.Caching.Abstractions;
-    using Neolution.Extensions.Caching.Distributed;
-    using Neolution.Extensions.Caching.RedisHybrid;
     using Neolution.Extensions.Caching.UnitTests.Models;
     using Shouldly;
     using Xunit;

Neolution.Extensions.Caching.UnitTests/DistributedCacheAsyncTests.cs

@@ -1,7 +1,6 @@
 namespace Neolution.Extensions.Caching.UnitTests
 {
     using System;
-    using System.Threading;
     using System.Threading.Tasks;
     using Microsoft.Extensions.DependencyInjection;
     using Neolution.Extensions.Caching.Abstractions;
@@ -108,13 +107,13 @@ public async Task RefreshedObjectDidNotExpire(IServiceCollection serviceCollecti
             await cache.SetWithOptionsAsync(TestCacheId.NonRefreshedFoobar, cacheObject, options);
 
             // After a wait of 500ms, refresh only one of the objects.
-            Thread.Sleep(TimeSpan.FromMilliseconds(500));
+            await Task.Delay(TimeSpan.FromMilliseconds(500));
 
             //await cache.RefreshAsync(TestCacheId.Foobar)
 
             // After a wait of 750ms, one of the objects should now be expired because its at least 1250ms (500+750) old at the moment.
             // But the refreshed object should still be valid for roughly another 250ms.
-            Thread.Sleep(TimeSpan.FromMilliseconds(750));
+            await Task.Delay(TimeSpan.FromMilliseconds(750));
 
             // Assert
             (await cache.GetAsync<string>(TestCacheId.Foobar)).ShouldBe(cacheObject);

Neolution.Extensions.Caching.UnitTests/DistributedCacheTests.cs

@@ -1,7 +1,7 @@
 namespace Neolution.Extensions.Caching.UnitTests
 {
     using System;
-    using System.Threading;
+    using System.Threading.Tasks;
     using Microsoft.Extensions.DependencyInjection;
     using Neolution.Extensions.Caching.Abstractions;
     using Neolution.Extensions.Caching.UnitTests.Models;
@@ -81,9 +81,10 @@ public void RemovedObjectCannotBeRetrievedAgain(IServiceCollection serviceCollec
         /// Tests if removed object cannot be retrieved again from the cache.
         /// </summary>
         /// <param name="serviceCollection">The service collection.</param>
+        /// <returns>A <see cref="Task"/> representing the asynchronous unit test.</returns>
         [Theory(Skip = "Refresh() is removed from interface (no strong use-case)")]
         [ClassData(typeof(ServiceCollectionTestDataCollection))]
-        public void RefreshedObjectDidNotExpire(IServiceCollection serviceCollection)
+        public async Task RefreshedObjectDidNotExpire(IServiceCollection serviceCollection)
         {
             // Assign
             using var serviceProvider = serviceCollection.BuildServiceProvider();
@@ -101,13 +102,13 @@ public void RefreshedObjectDidNotExpire(IServiceCollection serviceCollection)
             cache.SetWithOptions(TestCacheId.NonRefreshedFoobar, cacheObject, options);
 
             // After a wait of 500ms, refresh only one of the objects.
-            Thread.Sleep(TimeSpan.FromMilliseconds(500));
+            await Task.Delay(TimeSpan.FromMilliseconds(500));
 
             //cache.Refresh(TestCacheId.Foobar)
 
             // After a wait of 750ms, one of the objects should now be expired because its at least 1250ms (500+750) old at the moment.
             // But the refreshed object should still be valid for roughly another 250ms.
-            Thread.Sleep(TimeSpan.FromMilliseconds(750));
+            await Task.Delay(TimeSpan.FromMilliseconds(750));
 
             // Assert
             cache.Get<string>(TestCacheId.Foobar).ShouldBe(cacheObject);

Neolution.Extensions.Caching.UnitTests/MsgPackSerializerTests.cs

@@ -2,7 +2,6 @@
 {
     using System;
     using System.IO;
-    using MessagePack;
     using Neolution.Extensions.Caching.RedisHybrid;
     using Neolution.Extensions.Caching.UnitTests.Models;
     using Shouldly;

Neolution.Extensions.Caching.UnitTests/Neolution.Extensions.Caching.UnitTests.csproj

@@ -14,7 +14,7 @@
     <PackageReference Include="Foundatio.Xunit" Version="12.0.0" />
     <PackageReference Include="Microsoft.Extensions.Caching.Memory" Version="6.0.2" />
     <PackageReference Include="Microsoft.NET.Test.Sdk" Version="18.3.0" />
-    <PackageReference Include="Neolution.CodeAnalysis.TestsRuleset" Version="2.6.1">
+    <PackageReference Include="Neolution.CodeAnalysis.TestsRuleset" Version="3.2.2">
       <PrivateAssets>all</PrivateAssets>
       <IncludeAssets>runtime; build; native; contentfiles; analyzers; buildtransitive</IncludeAssets>
     </PackageReference>

Neolution.Extensions.Caching.UnitTests/RedisHybridCacheTests.cs

@@ -2,15 +2,13 @@
 {
     using System;
     using System.Threading.Tasks;
-    using Foundatio.Caching;
     using Foundatio.Xunit;
     using Microsoft.Extensions.DependencyInjection;
     using Microsoft.Extensions.Logging;
     using Neolution.Extensions.Caching.Abstractions;
     using Neolution.Extensions.Caching.RedisHybrid;
     using Neolution.Extensions.Caching.UnitTests.Models;
     using Shouldly;
-    using StackExchange.Redis;
     using Xunit;
     using Xunit.Abstractions;