Fix issues with GoogleSecret syntax and version parsing (#13)

This pull request fixes two issues with the
`GoogleSecret:SecretName:SecretVersion` syntax and version parsing in
the `GoogleSecretsProvider.cs` file. The code now uses a regular
expression to match the secret name and version, and removes the `}`
character from the version before calling the Google API.

Author: neotrow

CHANGELOG.md

@@ -7,6 +7,11 @@ and adheres to a project-specific [Versioning](/README.md).
 
 ## [Unreleased]
 
+### Fixed
+
+- Fixed an issue where the `GoogleSecret:SecretName:SecretVersion` syntax was not working as expected. Instead of using a starts with comparison, the code now uses a regular expression to match the secret name and version.
+- Fixed an issue where the `GoogleSecret:SecretName:SecretVersion` syntax was not working as expected. The version was parsed including the `}` character. The code now removes the `}` character from the version before calling the google api.
+
 ## [1.3.0] - 2024-03-12
 
 ### Added

GoogleSecrets/GoogleSecretsProvider.cs

@@ -4,6 +4,7 @@
     using System.Collections.Generic;
     using System.Linq;
     using System.Net.WebSockets;
+    using System.Text.RegularExpressions;
     using System.Threading.Tasks;
     using Google.Api.Gax;
     using Google.Api.Gax.ResourceNames;
@@ -108,15 +109,16 @@ void ScanExistingConfiguration(SecretManagerServiceClient secretManagerServiceCl
             {
                 var existingKeyValues = this.existingConfiguration.AsEnumerable();
                 // value will be in the format of {GoogleSecret:SecretName} or {GoogleSecret:SecretName:Version}
-                var keyValuesToReplace = existingKeyValues.Where(x => x.Value?.StartsWith($"{{GoogleSecret:{secret.SecretName.SecretId}") == true);
+                var regex = new Regex($@"\{{GoogleSecret:{secret.SecretName.SecretId}(?::(\w+))?}}");
+                var keyValuesToReplace = existingKeyValues.Where(x => !string.IsNullOrWhiteSpace(x.Value) && regex.IsMatch(x.Value));
 
                 foreach (var keyValue in keyValuesToReplace)
                 {
                     var replaceParams = keyValue.Value.Split(':');
                     string version = "latest";
                     if (replaceParams.Length >= 3)
                     {
-                        version = replaceParams[2];
+                        version = replaceParams[2].Substring(0, replaceParams[2].Length - 1);
                     }
 
                     SetSecretValue(secretManagerServiceClient, secret, keyValue.Key, version);