Fixed the regex test check

Author: dom-baur

src/lib/swissStandards.spec.ts

@@ -11,15 +11,20 @@ describe("Swiss standards test", () => {
     ["CH93 0000 0000 0000 0000 1", false],
     ["ch93 0076 2011 6238 5295 7", false],
     ["DE93 0076 2011 6238 5295 7", false],
-  ])("check if this swiss IBAN is valid or not", (iBanNumberToCheck, expected) => {
+  ])("check if the swiss IBAN number is valid or not", (iBanNumberToCheck, expected) => {
     expect(isValidSwissIbanNumber(iBanNumberToCheck)).toBe(expected);
   });
 
   test.each([
     [null as unknown as string, false],
     [undefined as unknown as string, false],
-    ["CH35 0023 0230 1234 5601 X", true],
-  ])("check if this siwss IBAN with letters is valid or not", (iBanNumberToCheck, expected) => {
+    ["CH3400762ABC123DEF456", true],
+    ["CH34 0076 2ABC 123D EF45 6", true],
+    ["Some random string", false],
+    ["DE34 0076 2ABC 123D EF45 3", false],
+    ["CH34 0076 2ABC 123D EF45 \n6", false],
+    ["CH34 0076 2ABC 123D EF45 !", false],
+  ])("check if the siwss IBAN number with letters is valid or not", (iBanNumberToCheck, expected) => {
     expect(isValidSwissIbanNumber(iBanNumberToCheck)).toBe(expected);
   });
 

src/lib/swissStandards.ts

@@ -20,8 +20,8 @@ export function isValidSwissIbanNumber(ibanNumber: string): boolean {
   //    - without spaces: "CHXXXXXXXXXXXXXXXXXXX"
   const compactIbanNumberWithoutWhiteSpaces = new RegExp(/^CH\d{2}[A-Z0-9]{17}$/);
 
-  // 3. Check if input matches one of the allowed formats
-  if (!compactIbanNumberWithWhiteSpaces.test(ibanNumber) && !compactIbanNumberWithoutWhiteSpaces.test(ibanNumber)) {
+  // 3. Check if the input matches one of the allowed formats
+  if (!(compactIbanNumberWithWhiteSpaces.test(ibanNumber) || compactIbanNumberWithoutWhiteSpaces.test(ibanNumber))) {
     return false;
   }
 
@@ -46,7 +46,7 @@ export function isValidSwissIbanNumber(ibanNumber: string): boolean {
 }
 
 /**
- * Validation of social insurance number with checking the checksum
+ * Validation of a social insurance number with checking the checksum
  * Validation according to https://www.sozialversicherungsnummer.ch/aufbau-neu.htm
  * @param socialInsuranceNumber The social insurance number to check
  * Must be in one of the following formats:
@@ -55,13 +55,13 @@ export function isValidSwissIbanNumber(ibanNumber: string): boolean {
  * @returns The result if the social insurance number is valid or not
  */
 export function isValidSwissSocialInsuranceNumber(socialInsuranceNumber: string): boolean {
-  // 1. Check if input is empty or only whitespace
+  // 1. Check if the input is empty or only a whitespace
   if (isNullOrWhitespace(socialInsuranceNumber)) {
     return false;
   }
 
   /**
-   * 2. Check if input matches accepted formats:
+   * 2. Check if the input matches one of the accepted formats:
    *    - With dots: 756.XXXX.XXXX.XX
    *    - Without dots: 756XXXXXXXXXX
    */