Update tooling (phpcs, psalm, GitHub actions)

Author: cracksalad

.github/workflows/ci.yml

@@ -13,7 +13,7 @@ jobs:
     name: Coding Standard
 
     steps:
-      - uses: actions/checkout@v4
+      - uses: actions/checkout@v5
       - name: Cache Composer dependencies
         uses: actions/cache@v4
         with:
@@ -31,10 +31,10 @@ jobs:
 
     steps:
       - name: Checkout code
-        uses: actions/checkout@v4
+        uses: actions/checkout@v5
 
       - name: Psalm
-        uses: docker://ghcr.io/psalm/psalm-github-actions:6.4.1
+        uses: docker://ghcr.io/psalm/psalm-github-actions
         with:
           args: --shepherd
 
@@ -51,11 +51,13 @@ jobs:
             phpunit: "10"
           - version: "8.3"
             phpunit: "10"
+          - version: "8.4"
+            phpunit: "10"
 
     name: "Test: PHP ${{ matrix.php.version }}"
 
     steps:
-      - uses: actions/checkout@v4
+      - uses: actions/checkout@v5
       - name: Cache Composer dependencies
         uses: actions/cache@v4
         with:
@@ -65,7 +67,7 @@ jobs:
         with:
           dev: no
           php_version: "${{ matrix.php.version }}"
-      - uses: php-actions/phpunit@v3
+      - uses: php-actions/phpunit@v4
         env:
           XDEBUG_MODE: coverage
         with:

.phive/phars.xml

@@ -1,6 +1,6 @@
 <?xml version="1.0" encoding="UTF-8"?>
 <phive xmlns="https://phar.io/phive">
-  <phar name="phpunit" version="^10.0.0" installed="10.5.45" location="./tools/phpunit" copy="true"/>
-  <phar name="psalm" version="~6.4.0" installed="6.4.1" location="./tools/psalm" copy="true"/>
+  <phar name="phpunit" version="^10.0 || ^11.0" installed="11.5.42" location="./tools/phpunit" copy="true"/>
+  <phar name="psalm" version="^6.4.0" installed="6.13.1" location="./tools/psalm" copy="true"/>
   <phar name="phpcpd" version="^6.0.0" installed="6.0.3" location="./tools/phpcpd" copy="true"/>
 </phive>

composer.json

@@ -22,7 +22,7 @@
         "php": ">=8.0"
     },
     "require-dev": {
-        "squizlabs/php_codesniffer": ">=3.7"
+        "squizlabs/php_codesniffer": "^4.0"
     },
     "prefer-stable": true,
     "autoload": {

phpcs.xml

@@ -27,7 +27,7 @@
         <exclude name="Generic.Files.LowercasedFilename"/>
         <exclude name="Generic.Formatting.DisallowMultipleStatements"/>
         <exclude name="Generic.Formatting.MultipleStatementAlignment.NotSameWarning"/>
-        <exclude name="Generic.Formatting.NoSpaceAfterCast"/>
+        <exclude name="Generic.Formatting.MultipleStatementAlignment.NotSame"/>
         <exclude name="Generic.Formatting.SpaceBeforeCast"/>
         <exclude name="Generic.Functions.OpeningFunctionBraceBsdAllman"/>
         <exclude name="Generic.Metrics.CyclomaticComplexity"/>                  <!-- see below -->
@@ -40,10 +40,6 @@
         <exclude name="Generic.Strings.UnnecessaryStringConcat"/>
         <exclude name="Generic.WhiteSpace.DisallowSpaceIndent"/>
         <exclude name="Generic.WhiteSpace.ScopeIndent"/>                        <!-- see below -->
-        
-        <!-- temporary -->
-        <exclude name="Generic.CodeAnalysis.UnusedFunctionParameter"/>
-        <exclude name="Generic.Metrics.NestingLevel"/>
     </rule>
     <rule ref="Generic.Arrays.ArrayIndent">
         <properties>
@@ -57,6 +53,11 @@
     <rule ref="Generic.Commenting">
         <type>warning</type>
     </rule>
+    <rule ref="Generic.Formatting.SpaceAfterCast">
+        <properties>
+            <property name="spacing" value="0"/>
+        </properties>
+    </rule>
     <rule ref="Generic.Formatting.SpaceAfterNot">
         <properties>
             <property name="spacing" value="0"/>
@@ -105,7 +106,6 @@
     <rule ref="Squiz.Strings.DoubleQuoteUsage"/>
     <rule ref="Squiz.Strings.EchoedStrings"/>
     <rule ref="Squiz.WhiteSpace.CastSpacing"/>
-    <rule ref="Squiz.WhiteSpace.LanguageConstructSpacing"/>
     <rule ref="Squiz.WhiteSpace.ScopeKeywordSpacing"/>
     <rule ref="Squiz.WhiteSpace.SemicolonSpacing"/>
 </ruleset>

psalm.baseline.xml

@@ -7,5 +7,9 @@
       <code>msgpack_serialize($item)</code>
       <code>msgpack_unserialize($this->current)</code>
     </UndefinedFunction>
+    <TooManyArguments>
+      <code>lz4_compress($serialized)</code>
+      <code>lz4_uncompress($compressed)</code>
+    </TooManyArguments>
   </file>
 </files>

psalm.xml

@@ -15,5 +15,6 @@
     </projectFiles>
 
     <issueHandlers>
+      <MissingOverrideAttribute errorLevel="suppress"/>
     </issueHandlers>
 </psalm>

src/ArrayBuffer.php

@@ -6,6 +6,7 @@
 /**
  * @template E of object|array|scalar|null
  * @implements ArrayBufferInterface<E>
+ * @api
  * @author Andreas Wahlen
  */
 class ArrayBuffer implements ArrayBufferInterface {

src/LargeArrayBuffer.php

@@ -6,6 +6,7 @@
 /**
  * @template E of object|array|scalar|null
  * @implements ArrayBufferInterface<E>
+ * @api
  * @author Andreas Wahlen
  */
 class LargeArrayBuffer implements ArrayBufferInterface {

test/ArrayBufferTest.php

@@ -22,6 +22,7 @@ public static function provideTestData(): array {
   /**
    * @dataProvider provideTestData
    */
+  //#[DataProvider('provideTestData')]
   public function testBuffer(int $items, int $threshold): void {
     $o = new \stdClass();
     $o->foo = 'hello world!'.PHP_EOL;

test/LargeArrayBufferTest.php

@@ -107,7 +107,7 @@ public function testToJSON(): void {
     $this->assertEquals(json_encode([$o, $o], JSON_THROW_ON_ERROR), $json);
   }
 
-  public function provideItems(): array {
+  public static function provideItems(): array {
     return [
       [['hello world!', 'just another string']]
     ];