fix: keep stale job timeout as optional param to avoid breaking change

Author: HenrikVogel

Classes/Command/SchedulerCommandController.php

@@ -54,11 +54,13 @@ public function injectConnection(Connection $connection): void
      * Reset stale jobs that have not changed for too long.
      *
      * @param string $groupName Free jobs in this group only
+     * @param ?int $minutes @deprecated Use staleJobTimeout configuration setting instead.
      */
     public function resetStaleJobsCommand(
         string $groupName,
+        ?int $minutes = 10
     ): void {
-        $freed = $this->scheduler->resetStaleJobs($groupName);
+        $freed = $this->scheduler->resetStaleJobs($groupName, $minutes);
         if ($freed) {
             $this->outputLine('Freed ' . $freed . ' stale jobs.');
         }

Classes/Domain/AbstractScheduler.php

@@ -283,15 +283,19 @@ public function activity(ScheduledJob $job): void
      * Reset stale jobs that have not changed for too long.
      *
      * @param string $groupName Free jobs in this group only
+     * @param int|null $minutes Only free jobs that are stale for at least this many minutes. @deprecated Use staleJobTimeout configuration setting instead.
      * @throws Exception
      * @return int Number of freed jobs
      */
-    public function resetStaleJobs(string $groupName): int {
+    public function resetStaleJobs(
+        string $groupName,
+        ?int $minutes = null
+    ): int {
         return $this->dbal->executeQuery(
             sql: static::RESET_STALE_JOBS_QUERY,
             params: [
                 'groupName' => $groupName,
-                'seconds' => max($this->staleJobTimeoutSecs, 1),
+                'seconds' => max($minutes === null ?  $this->staleJobTimeoutSecs : $minutes * 60, 1),
             ],
             types: [
                 'groupName' => Types::STRING,

Classes/Domain/Scheduler.php

@@ -23,7 +23,7 @@ public function fail(ScheduledJob $job, string $reason): void;
 
     public function activity(ScheduledJob $job): void;
 
-    public function resetStaleJobs(string $groupName): int;
+    public function resetStaleJobs(string $groupName, ?int $minutes = null): int;
 
     public function getConnection(): Connection;