SqlBuilder: sort all tables in parseJoinConditions (#181) (#182)

syky01 · dg · commit deb4682e5f27 · 2017-09-09T01:11:24.000+02:00
diff --git a/src/Database/Table/SqlBuilder.php b/src/Database/Table/SqlBuilder.php
@@ -540,7 +540,7 @@ protected function parseJoinConditions(&$joins, $joinConditions): array
 		}
 		$this->parameters['joinConditionSorted'] = [];
 		if (count($joinConditions)) {
-			while (reset($tableJoins)) {
+			while ($tableJoins) {
 				$this->getSortedJoins(key($tableJoins), $leftJoinDependency, $tableJoins, $joins);
 			}
 		}

Original file line number	Diff line number	Diff line change
`@@ -540,7 +540,7 @@ protected function parseJoinConditions(&$joins, $joinConditions): array`
`540`	`540`	`}`
`541`	`541`	`$this->parameters['joinConditionSorted'] = [];`
`542`	`542`	`if (count($joinConditions)) {`
`543`		`- while (reset($tableJoins)) {`
	`543`	`+ while ($tableJoins) {`
`544`	`544`	`$this->getSortedJoins(key($tableJoins), $leftJoinDependency, $tableJoins, $joins);`
`545`	`545`	`}`
`546`	`546`	`}`