Pylint updates (#282)

* reprep 0.20.3 (#260) (#261)

* Updates errors and aireos files for pylint.

* ASA pylint updates.

* EOS pylint updates.

* F5 pylint.

* IOS updates.

* xe wlc pylint updates.

* Juniper pylint.

* nxos pylint

* Final lints.

* Formatting

* Fix my mistakes.

* Test updates from linting.

---------

Co-authored-by: Jeff Kala <48843785+jeffkala@users.noreply.github.com>

Author: jvanderaa

pyntc/devices/aireos_device.py

@@ -1086,7 +1086,7 @@ def open(self, confirm_active=True):
         if self.connected:
             try:
                 self.native.find_prompt()
-            except:  # noqa E722
+            except:  # noqa E722  pylint: disable=bare-except
                 self._connected = False
 
         if not self.connected:
@@ -1198,8 +1198,8 @@ def redundancy_mode(self):
             'sso enabled'
             >>>
         """
-        ha = self.show("show redundancy summary")
-        ha_mode = re.search(r"^\s*Redundancy\s+Mode\s*=\s*(.+?)\s*$", ha, re.M)
+        high_availability = self.show("show redundancy summary")
+        ha_mode = re.search(r"^\s*Redundancy\s+Mode\s*=\s*(.+?)\s*$", high_availability, re.M)
         log.debug("Host %s: Redundancy mode: {ha_mode.group(1).lower()}", self.host, ha_mode.group(1).lower())
         return ha_mode.group(1).lower()
 
@@ -1400,13 +1400,13 @@ def startup_config(self):
         """
         raise NotImplementedError
 
-    def transfer_image_to_ap(self, image, timeout=None):
+    def transfer_image_to_ap(self, image):
         """
         Transfer ``image`` file to all APs connected to the WLC.
 
         Args:
             image (str): The image that should be sent to the APs.
-            timeout (int): The max time to wait for all APs to download the image.
+            timeout (int): Removed, The max time to wait for all APs to download the image.
 
         Returns:
             bool: True if AP images are transferred or swapped, False otherwise.
@@ -1513,7 +1513,7 @@ def uptime_string(self):
             >>>
         """
         days, hours, minutes = self._uptime_components()
-        return "%02d:%02d:%02d:00" % (days, hours, minutes)
+        return f"{days:02d}:{hours:02d}:{minutes:02d}:00"
 
     @property
     def wlans(self):

pyntc/devices/asa_device.py

@@ -76,11 +76,11 @@ def _file_copy(self, src: str, dest: str, file_system: str) -> None:
         self.enable()
 
         if not self.file_copy_remote_exists(src, dest, file_system):
-            fc: CiscoAsaFileTransfer = self._file_copy_instance(src, dest, file_system)
+            file_copy: CiscoAsaFileTransfer = self._file_copy_instance(src, dest, file_system)
 
             try:
-                fc.establish_scp_conn()
-                fc.transfer_file()
+                file_copy.establish_scp_conn()
+                file_copy.transfer_file()
             # Allow EOFErrors to be caught and only raise an error if the file is not actually on the device
             except EOFError:
                 log.error("Host %s: EOF error.", self.host)
@@ -90,7 +90,7 @@ def _file_copy(self, src: str, dest: str, file_system: str) -> None:
                 raise FileTransferError
             finally:
                 log.error("Host %s: An error occurred when transferring file %s.", self.host, src)
-                fc.close_scp_chan()
+                file_copy.close_scp_chan()
 
             if not self.file_copy_remote_exists(src, dest, file_system):
                 log.error(
@@ -109,9 +109,9 @@ def _file_copy_instance(
         if dest is None:
             dest = os.path.basename(src)
 
-        fc = CiscoAsaFileTransfer(self.native, src, dest, file_system=file_system)
-        log.debug("Host %s: File copy instance %s.", self.host, fc)
-        return fc
+        file_copy = CiscoAsaFileTransfer(self.native, src, dest, file_system=file_system)
+        log.debug("Host %s: File copy instance %s.", self.host, file_copy)
+        return file_copy
 
     def _get_file_system(self):
         """Determine the default file system or directory for device.
@@ -261,7 +261,7 @@ def _show_vlan(self):
         log.debug("Host %s: Successfully executed command 'show vlan' with responses %s.", self.host, show_vlan_out)
         return show_vlan_out.split(",")
 
-    def _uptime_components(self, uptime_full_string):
+    def _uptime_components(self, uptime_full_string):  # pylint: disable=no-self-use
         match_days = re.search(r"(\d+) days?", uptime_full_string)
         match_hours = re.search(r"(\d+) hours?", uptime_full_string)
         match_minutes = re.search(r"(\d+) mins?", uptime_full_string)
@@ -283,7 +283,7 @@ def _uptime_to_seconds(self, uptime_full_string):
 
     def _uptime_to_string(self, uptime_full_string):
         days, hours, minutes = self._uptime_components(uptime_full_string)
-        return "%02d:%02d:%02d:00" % (days, hours, minutes)
+        return f"{days:02d}:{hours:02d}:{minutes:02d}:00"
 
     def _wait_for_device_reboot(self, timeout=3600):
         start = time.time()
@@ -292,7 +292,7 @@ def _wait_for_device_reboot(self, timeout=3600):
                 self.open()
                 log.debug("Host %s: Device rebooted.", self.host)
                 return
-            except:  # noqa E722 # nosec
+            except:  # noqa E722 # nosec   # pylint: disable=bare-except
                 pass
 
         # TODO: Get proper hostname parameter
@@ -352,8 +352,8 @@ def backup_running_config(self, filename):
         Args:
             filename (str): Name of backup file.
         """
-        with open(filename, "w") as f:
-            f.write(self.running_config)
+        with open(filename, "w", encoding="utf-8") as file_name:
+            file_name.write(self.running_config)
 
         log.debug("Host %s: Running config backed up to %s.", self.host, self.running_config)
 
@@ -498,7 +498,7 @@ def enable_scp(self) -> None:
         device.save()
 
     @property
-    def facts(self):
+    def facts(self):  # pylint: disable=invalid-overridden-method
         """Implement this once facts re-factor is done."""
         return {}
 
@@ -542,7 +542,7 @@ def file_copy(
         self.enable_scp()
         self._file_copy(src, dest, file_system)
         if peer:
-            self.peer_device._file_copy(src, dest, file_system)
+            self.peer_device._file_copy(src, dest, file_system)  # pylint: disable=protected-access
 
         # logging removed because it messes up unit test mock_basename.assert_not_called()
         # for tests test_file_copy_no_peer_pass_args, test_file_copy_include_peer
@@ -573,8 +573,8 @@ def file_copy_remote_exists(self, src, dest=None, file_system=None):
         if file_system is None:
             file_system = self._get_file_system()
 
-        fc = self._file_copy_instance(src, dest, file_system=file_system)
-        if fc.check_file_exists() and fc.compare_md5():
+        file_copy = self._file_copy_instance(src, dest, file_system=file_system)
+        if file_copy.check_file_exists() and file_copy.compare_md5():
             log.debug("Host %s: File %s already exists on remote.", self.host, src)
             return True
 
@@ -630,14 +630,13 @@ def ip_address(self) -> Union[IPv4Address, IPv6Address]:
             >>>
         """
         try:
-            ip = ip_address(self.host)
+            ip_add = ip_address(self.host)
         except ValueError:
             # Assume hostname was used, and retrieve resolved IP from paramiko transport
             log.error("Host %s: value error for ip address used to establish connection.", self.host)
-            ip = ip_address(self.native.remote_conn.transport.getpeername()[0])
-
-        log.debug("Host %s: ip address used to establish connection %s.", self.host, ip)
-        return ip
+            ip_add = ip_address(self.native.remote_conn.transport.getpeername()[0])
+        log.debug("Host %s: ip address used to establish connection %s.", self.host, ip_add)
+        return ip_add
 
     @property
     def ipv4_addresses(self) -> Dict[str, List[IPv4Address]]:
@@ -718,7 +717,7 @@ def open(self):
         if self._connected:
             try:
                 self.native.find_prompt()
-            except:  # noqa E722
+            except:  # noqa E722  pylint: disable=bare-except
                 self._connected = False
 
         if not self._connected:
@@ -1028,7 +1027,7 @@ def save(self, filename="startup-config"):
         Returns:
             bool: True if configuration saved succesfully.
         """
-        command = "copy running-config %s" % filename
+        command = f"copy running-config {filename}"
         # Changed to send_command_timing to not require a direct prompt return.
         self.native.send_command_timing(command)
         # If the user has enabled 'file prompt quiet' which dose not require any confirmation or feedback.
@@ -1056,26 +1055,26 @@ def set_boot_options(self, image_name, **vendor_specifics):
         if file_system is None:
             file_system = self._get_file_system()
 
-        file_system_files = self.show("dir {0}".format(file_system))
+        file_system_files = self.show(f"dir {file_system}")
         if re.search(image_name, file_system_files) is None:
             log.error("Host %s: File not found error for image %s.", self.host, image_name)
             raise NTCFileNotFoundError(
                 # TODO: Update to use hostname
                 hostname=self.host,
                 file=image_name,
-                dir=file_system,
+                directory=file_system,
             )
 
         current_images = current_boot.splitlines()
-        commands_to_exec = ["no {0}".format(image) for image in current_images]
-        commands_to_exec.append("boot system {0}/{1}".format(file_system, image_name))
+        commands_to_exec = [f"no {image}" for image in current_images]
+        commands_to_exec.append(f"boot system {file_system}/{image_name}")
         self.config(commands_to_exec)
 
         self.save()
         if self.boot_options["sys"] != image_name:
             log.error("Host %s: Setting boot command did not yield expected results", self.host)
             raise CommandError(
-                command="boot system {0}/{1}".format(file_system, image_name),
+                command=f"boot system {file_system}/{image_name}",
                 message="Setting boot command did not yield expected results",
             )
 
@@ -1224,4 +1223,4 @@ def vlans(self):
 class RebootSignal(NTCError):
     """Not implemented."""
 
-    pass
+    pass  # pylint: disable=unnecessary-pass