test: adjust tests + also test non-DOM environment

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>

Author: susnux

package.json

@@ -42,8 +42,10 @@
     "lint": "eslint .",
     "lint:fix": "eslint --fix lib tests",
     "prerelease:format-changelog": "node build/format-changelog.mjs",
-    "test": "LANG=en-US vitest run",
+    "test": "npm run test:dom && npm run test:node",
     "test:coverage": "LANG=en-US vitest run --coverage",
+    "test:dom": "LANG=en-US vitest run",
+    "test:node": "LANG=en-US vitest run --environment node",
     "test:watch": "LANG=en-US vitest watch"
   },
   "browserslist": [

tests/date.test.ts

@@ -13,7 +13,7 @@ import * as localeModule from '../lib/locale.ts'
 vi.mock('../lib/locale.ts')
 const { getCanonicalLocale } = localeModule as Mocked<typeof localeModule>
 
-declare let window: Nextcloud.v24.WindowWithGlobals
+declare let globalThis: Nextcloud.v29.WindowWithGlobals
 
 describe('date', () => {
 	describe('getFirstDay', () => {
@@ -35,7 +35,7 @@ describe('date', () => {
 
 		beforeEach(() => {
 			// @ts-expect-error - Mocking for tests
-			delete window.firstDay
+			delete globalThis.firstDay
 		})
 
 		afterEach(() => {
@@ -44,38 +44,38 @@ describe('date', () => {
 			Object.defineProperty(Intl.Locale.prototype, 'weekInfo', originalWeekInfoDescriptor)
 		})
 
-		it('returns `window.firstDate` when defined', () => {
-			window.firstDay = 3
+		it('returns `globalThis.firstDate` when defined', () => {
+			globalThis.firstDay = 3
 			expect(getFirstDay()).toBe(3)
 		})
 
-		it('returns 1 (Monday) in "de-DE" locale when `window.firstDate` is not defined but `Intl.weekInfo` is defined (Node.js, Samsung Internet)', () => {
+		it('returns 1 (Monday) in "de-DE" locale when `globalThis.firstDate` is not defined but `Intl.weekInfo` is defined (Node.js, Samsung Internet)', () => {
 			getCanonicalLocale.mockReturnValue('de-DE')
 			expect(getFirstDay()).toBe(1)
 		})
 
-		it('returns 0 (Sunday) in "en-US" locale when `window.firstDate` is not defined but `Intl.weekInfo` is defined (Node.js, Samsung Internet)', () => {
+		it('returns 0 (Sunday) in "en-US" locale when `globalThis.firstDate` is not defined but `Intl.weekInfo` is defined (Node.js, Samsung Internet)', () => {
 			getCanonicalLocale.mockReturnValue('en-US')
 			expect(getFirstDay()).toBe(0)
 		})
 
-		it('returns 1 (Monday) in "de-DE" locale when `window.firstDate` is not defined but `Intl.getWeekInfo` is defined (Chromium, Safari)', () => {
+		it('returns 1 (Monday) in "de-DE" locale when `globalThis.firstDate` is not defined but `Intl.getWeekInfo` is defined (Chromium, Safari)', () => {
 			getCanonicalLocale.mockReturnValue('de-DE')
 			// getWeekInfo is available, weekInfo is not available (Chromium, Safari)
 			Intl.Locale.prototype.getWeekInfo = mockGetWeekInfo
 			delete Intl.Locale.prototype.weekInfo
 			expect(getFirstDay()).toBe(1)
 		})
 
-		it('returns 0 (Sunday) in "en-US" locale when `window.firstDate` is not defined but `Intl.getWeekInfo` is defined (Chromium, Safari)', () => {
+		it('returns 0 (Sunday) in "en-US" locale when `globalThis.firstDate` is not defined but `Intl.getWeekInfo` is defined (Chromium, Safari)', () => {
 			getCanonicalLocale.mockReturnValue('en-US')
 			// getWeekInfo is available, weekInfo is not available (Chromium, Safari)
 			Intl.Locale.prototype.getWeekInfo = mockGetWeekInfo
 			delete Intl.Locale.prototype.weekInfo
 			expect(getFirstDay()).toBe(0)
 		})
 
-		it('returns 1 (Monday) when neither `window.firstDate` nor `Intl.Locale.getWeekInfo`/`weekInfo` is defined (Firefox)', () => {
+		it('returns 1 (Monday) when neither `globalThis.firstDate` nor `Intl.Locale.getWeekInfo`/`weekInfo` is defined (Firefox)', () => {
 			delete Intl.Locale.prototype.getWeekInfo
 			delete Intl.Locale.prototype.weekInfo
 			expect(getFirstDay()).toBe(1)
@@ -85,20 +85,20 @@ describe('date', () => {
 	describe('getDayNames', () => {
 		afterEach(() => {
 			// @ts-expect-error - Mocking for tests
-			delete window.dayNames
+			delete globalThis.dayNames
 		})
 
-		it('returns `window.dayNames` when defined', () => {
-			window.dayNames = ['Day 0', 'Day 1', 'Day 2', 'Day 3', 'Day 4', 'Day 5', 'Day 6']
-			expect(getDayNames()).toEqual(window.dayNames)
+		it('returns `globalThis.dayNames` when defined', () => {
+			globalThis.dayNames = ['Day 0', 'Day 1', 'Day 2', 'Day 3', 'Day 4', 'Day 5', 'Day 6']
+			expect(getDayNames()).toEqual(globalThis.dayNames)
 		})
 
-		it('returns English day names in "en-US" locale when `window.dayNames` is not defined', () => {
+		it('returns English day names in "en-US" locale when `globalThis.dayNames` is not defined', () => {
 			getCanonicalLocale.mockReturnValue('en-US')
 			expect(getDayNames()).toEqual(['Sunday', 'Monday', 'Tuesday', 'Wednesday', 'Thursday', 'Friday', 'Saturday'])
 		})
 
-		it('returns German day names in "de-DE" locale when `window.dayNames` is not defined', () => {
+		it('returns German day names in "de-DE" locale when `globalThis.dayNames` is not defined', () => {
 			getCanonicalLocale.mockReturnValue('de-DE')
 			expect(getDayNames()).toEqual(['Sonntag', 'Montag', 'Dienstag', 'Mittwoch', 'Donnerstag', 'Freitag', 'Samstag'])
 		})
@@ -107,20 +107,20 @@ describe('date', () => {
 	describe('getDayNamesShort', () => {
 		afterEach(() => {
 			// @ts-expect-error - Mocking for tests
-			delete window.dayNamesShort
+			delete globalThis.dayNamesShort
 		})
 
-		it('returns `window.dayNamesShort` when defined', () => {
-			window.dayNamesShort = ['D. 0', 'D. 1', 'D. 2', 'D. 3', 'D. 4', 'D. 5', 'D. 6']
-			expect(getDayNamesShort()).toEqual(window.dayNamesShort)
+		it('returns `globalThis.dayNamesShort` when defined', () => {
+			globalThis.dayNamesShort = ['D. 0', 'D. 1', 'D. 2', 'D. 3', 'D. 4', 'D. 5', 'D. 6']
+			expect(getDayNamesShort()).toEqual(globalThis.dayNamesShort)
 		})
 
-		it('returns English short day names from `Intl` in "en-US" locale when `window.dayNamesShort` is not defined', () => {
+		it('returns English short day names from `Intl` in "en-US" locale when `globalThis.dayNamesShort` is not defined', () => {
 			getCanonicalLocale.mockReturnValue('en-US')
 			expect(getDayNamesShort()).toEqual(['Sun', 'Mon', 'Tue', 'Wed', 'Thu', 'Fri', 'Sat'])
 		})
 
-		it('returns German short day names from `Intl` in "de-DE" locale when `window.dayNamesShort` is not defined', () => {
+		it('returns German short day names from `Intl` in "de-DE" locale when `globalThis.dayNamesShort` is not defined', () => {
 			getCanonicalLocale.mockReturnValue('de-DE')
 			expect(getDayNamesShort()).toEqual(['So', 'Mo', 'Di', 'Mi', 'Do', 'Fr', 'Sa'])
 		})
@@ -129,20 +129,20 @@ describe('date', () => {
 	describe('getDayNamesMin', () => {
 		afterEach(() => {
 			// @ts-expect-error - Mocking for tests
-			delete window.dayNamesMin
+			delete globalThis.dayNamesMin
 		})
 
-		it('returns `window.dayNamesMin` when defined', () => {
-			window.dayNamesMin = ['D0', 'D1', 'D2', 'D3', 'D4', 'D5', 'D6']
-			expect(getDayNamesMin()).toEqual(window.dayNamesMin)
+		it('returns `globalThis.dayNamesMin` when defined', () => {
+			globalThis.dayNamesMin = ['D0', 'D1', 'D2', 'D3', 'D4', 'D5', 'D6']
+			expect(getDayNamesMin()).toEqual(globalThis.dayNamesMin)
 		})
 
-		it('returns English narrow day names from `Intl` in "en-US" locale when `window.dayNamesMin` is not defined', () => {
+		it('returns English narrow day names from `Intl` in "en-US" locale when `globalThis.dayNamesMin` is not defined', () => {
 			getCanonicalLocale.mockReturnValue('en-US')
 			expect(getDayNamesMin()).toEqual(['S', 'M', 'T', 'W', 'T', 'F', 'S'])
 		})
 
-		it('returns German narrow day names from `Intl` in "de-DE" locale when `window.dayNamesMin` is not defined', () => {
+		it('returns German narrow day names from `Intl` in "de-DE" locale when `globalThis.dayNamesMin` is not defined', () => {
 			getCanonicalLocale.mockReturnValue('de-DE')
 			expect(getDayNamesMin()).toEqual(['S', 'M', 'D', 'M', 'D', 'F', 'S'])
 		})
@@ -151,20 +151,20 @@ describe('date', () => {
 	describe('getMonthNames', () => {
 		afterEach(() => {
 			// @ts-expect-error - Mocking for tests
-			delete window.monthNames
+			delete globalThis.monthNames
 		})
 
-		it('returns `window.monthNames` when defined', () => {
-			window.monthNames = ['Month 0', 'Month 1', 'Month 2', 'Month 3', 'Month 4', 'Month 5', 'Month 6', 'Month 7', 'Month 8', 'Month 9', 'Month 10', 'Month 11']
-			expect(getMonthNames()).toEqual(window.monthNames)
+		it('returns `globalThis.monthNames` when defined', () => {
+			globalThis.monthNames = ['Month 0', 'Month 1', 'Month 2', 'Month 3', 'Month 4', 'Month 5', 'Month 6', 'Month 7', 'Month 8', 'Month 9', 'Month 10', 'Month 11']
+			expect(getMonthNames()).toEqual(globalThis.monthNames)
 		})
 
-		it('returns English month names from `Intl` in "en-US" locale when `window.monthNames` is not defined', () => {
+		it('returns English month names from `Intl` in "en-US" locale when `globalThis.monthNames` is not defined', () => {
 			getCanonicalLocale.mockReturnValue('en-US')
 			expect(getMonthNames()).toEqual(['January', 'February', 'March', 'April', 'May', 'June', 'July', 'August', 'September', 'October', 'November', 'December'])
 		})
 
-		it('returns German month names from `Intl` in "de-DE" locale when `window.monthNames` is not defined', () => {
+		it('returns German month names from `Intl` in "de-DE" locale when `globalThis.monthNames` is not defined', () => {
 			getCanonicalLocale.mockReturnValue('de-DE')
 			expect(getMonthNames()).toEqual(['Januar', 'Februar', 'März', 'April', 'Mai', 'Juni', 'Juli', 'August', 'September', 'Oktober', 'November', 'Dezember'])
 		})
@@ -173,20 +173,20 @@ describe('date', () => {
 	describe('getMonthNamesShort', () => {
 		afterEach(() => {
 			// @ts-expect-error - Mocking for tests
-			delete window.monthNamesShort
+			delete globalThis.monthNamesShort
 		})
 
-		it('returns `window.monthNamesShort` when defined', () => {
-			window.monthNamesShort = ['M. 0', 'M. 1', 'M. 2', 'M. 3', 'M. 4', 'M. 5', 'M. 6', 'M. 7', 'M. 8', 'M. 9', 'M. 10', 'M. 11']
-			expect(getMonthNamesShort()).toEqual(window.monthNamesShort)
+		it('returns `globalThis.monthNamesShort` when defined', () => {
+			globalThis.monthNamesShort = ['M. 0', 'M. 1', 'M. 2', 'M. 3', 'M. 4', 'M. 5', 'M. 6', 'M. 7', 'M. 8', 'M. 9', 'M. 10', 'M. 11']
+			expect(getMonthNamesShort()).toEqual(globalThis.monthNamesShort)
 		})
 
-		it('returns English short month names from `Intl` in "en-US" locale when `window.monthNamesShort` is not defined', () => {
+		it('returns English short month names from `Intl` in "en-US" locale when `globalThis.monthNamesShort` is not defined', () => {
 			getCanonicalLocale.mockReturnValue('en-US')
 			expect(getMonthNamesShort()).toEqual(['Jan', 'Feb', 'Mar', 'Apr', 'May', 'Jun', 'Jul', 'Aug', 'Sep', 'Oct', 'Nov', 'Dec'])
 		})
 
-		it('returns German short month names from `Intl` in "de-DE" locale when `window.monthNamesShort` is not defined', () => {
+		it('returns German short month names from `Intl` in "de-DE" locale when `globalThis.monthNamesShort` is not defined', () => {
 			getCanonicalLocale.mockReturnValue('de-DE')
 			expect(getMonthNamesShort()).toEqual(['Jan', 'Feb', 'Mär', 'Apr', 'Mai', 'Jun', 'Jul', 'Aug', 'Sep', 'Okt', 'Nov', 'Dez'])
 		})

tests/gettext.test.ts

@@ -7,7 +7,7 @@ import { po } from 'gettext-parser'
 import { beforeEach, describe, expect, it, vi } from 'vitest'
 import { getGettextBuilder } from '../lib/gettext.ts'
 
-const setLanguage = (lang: string) => document.documentElement.setAttribute('lang', lang)
+const setLanguage = (lang: string) => { globalThis._nc_l10n_language = lang }
 
 describe('gettext', () => {
 	beforeEach(() => {

tests/is-rtl.test.ts

@@ -0,0 +1,50 @@
+/*!
+ * SPDX-FileCopyrightText: 2025 Nextcloud GmbH and Nextcloud contributors
+ * SPDX-License-Identifier: GPL-3.0-or-later
+ */
+
+import { beforeEach, describe, expect, it } from 'vitest'
+import { isRTL } from '../lib/locale'
+
+const setLanguage = (lang: string) => { globalThis._nc_l10n_language = lang }
+
+describe('isRTL', () => {
+	beforeEach(() => { globalThis._nc_l10n_locale = 'en' })
+
+	it('falls back to English which is LTR', () => {
+		// Expect fallback which is English = LTR
+		expect(isRTL()).toBe(false)
+	})
+
+	it('uses the given argument over the current language', () => {
+		// If a value is given it should use that language over the fallback
+		expect(isRTL('ar')).toBe(true)
+		setLanguage('ar')
+		expect(isRTL('de')).toBe(false)
+	})
+
+	it('without an argument the current language is used', () => {
+		// It uses the configured language
+		setLanguage('he')
+		expect(isRTL()).toBe(true)
+	})
+
+	it('without an argument the current language is used', () => {
+		// It uses the configured language
+		setLanguage('he')
+		expect(isRTL()).toBe(true)
+	})
+
+	it('handles Uzbek Afghan correctly', () => {
+		// Given as argument
+		expect(isRTL('uz')).toBe(false)
+		expect(isRTL('uz-AF')).toBe(true)
+
+		// configured as current language
+		setLanguage('uz')
+		expect(isRTL()).toBe(false)
+
+		setLanguage('uz-AF')
+		expect(isRTL()).toBe(true)
+	})
+})

tests/loadTranslations.test.ts

@@ -10,46 +10,43 @@ import { setupServer } from 'msw/node'
 import { afterAll, afterEach, beforeAll, beforeEach, describe, expect, it, vi } from 'vitest'
 import { loadTranslations, register, translate, unregister } from '../lib/translation.ts'
 
-const setLanguage = (lang: string) => document.documentElement.setAttribute('lang', lang)
+vi.mock('@nextcloud/router', () => ({
+	generateFilePath: (app: string, type: string, path: string) => `http://localhost/${app}/${type}/${path}`,
+}))
+
+/**
+ * Mock the langauge
+ *
+ * @param lang - The language to mock
+ */
+function setLanguage(lang: string): void {
+	globalThis._nc_l10n_language = lang
+}
 
 const requestHandlers = [
-	http.get('/myapp/l10n/de.json', () => HttpResponse.json({
+	http.get('http://localhost/myapp/l10n/de.json', () => HttpResponse.json({
 		translations: {
 			'Hello world!': 'Hallo Welt!',
 		},
 	})),
 	// Response with empty body
-	http.get('/empty/l10n/de.json', () => HttpResponse.json()),
+	http.get('http://localhost/empty/l10n/de.json', () => HttpResponse.json()),
 	// Response contains JSON but no translations
-	http.get('/missing-bundle/l10n/de.json', () => HttpResponse.json({})),
+	http.get('http://localhost/missing-bundle/l10n/de.json', () => HttpResponse.json({})),
 	// Response contains JSON but the translations are invalid
-	http.get('/invalid/l10n/de.json', () => HttpResponse.json({
+	http.get('http://localhost/invalid/l10n/de.json', () => HttpResponse.json({
 		translations: 'invalid',
 	})),
 	// errors
-	http.get('/404/l10n/de.json', () => HttpResponse.json({}, { status: 404 })),
-	http.get('/500/l10n/de.json', () => HttpResponse.json({}, { status: 500 })),
-	http.get('/networkissue/l10n/de.json', () => HttpResponse.error()),
+	http.get('http://localhost/404/l10n/de.json', () => HttpResponse.json({}, { status: 404 })),
+	http.get('http://localhost/500/l10n/de.json', () => HttpResponse.json({}, { status: 500 })),
+	http.get('http://localhost/networkissue/l10n/de.json', () => HttpResponse.error()),
 ]
 
 const server: SetupServerApi = setupServer(...requestHandlers)
 
 describe('loadTranslations', () => {
 	beforeAll(() => {
-		// Mock some server state
-
-		(window as any)._oc_webroot = '';
-
-		(window as any)._oc_appswebroots = {
-			404: '/404',
-			500: '/500',
-			empty: '/empty',
-			invalid: '/invalid',
-			'missing-bundle': '/missing-bundle',
-			myapp: '/myapp',
-			networkissue: '/networkissue',
-		}
-
 		server.listen({ onUnhandledRequest: 'error' })
 	})
 
@@ -160,6 +157,6 @@ describe('loadTranslations', () => {
 	})
 
 	it('does reject on empty response', async () => {
-		expect(() => loadTranslations('empty')).rejects.toThrowErrorMatchingInlineSnapshot('[Error: Invalid content of translation bundle]')
+		await expect(() => loadTranslations('empty')).rejects.toThrowErrorMatchingInlineSnapshot('[Error: Invalid content of translation bundle]')
 	})
 })