fix(e2e): correct selectors for questions, results tabs, and view routing

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

Signed-off-by: Peter Ringelmann <peter.ringelmann@nextcloud.com>

Author: pringelmann

playwright/e2e/question-editing.spec.ts

@@ -11,14 +11,14 @@ import { QuestionType } from '../support/sections/QuestionType'
 
 const test = mergeTests(randomUserTest, appNavigationTest, formTest)
 
-test.beforeEach(async ({ page, appNavigation, form }) => {
-	await page.goto('apps/forms')
-	await page.waitForURL(/apps\/forms$/)
-	await appNavigation.clickNewForm()
-	await form.fillTitle('Editing test form')
-})
-
 test.describe('Question editing lifecycle', () => {
+	test.beforeEach(async ({ page, appNavigation, form }) => {
+		await page.goto('apps/forms')
+		await page.waitForURL(/apps\/forms$/)
+		await appNavigation.clickNewForm()
+		await form.fillTitle('Editing test form')
+	})
+
 	const questionTypes = [
 		QuestionType.ShortAnswer,
 		QuestionType.LongAnswer,

playwright/support/sections/FormSection.ts

@@ -46,10 +46,10 @@ export class FormSection {
 
 	public async getQuestions(): Promise<QuestionSection[]> {
 		return this.page
-			.locator('main section')
+			.getByRole('listitem', { name: /Question number \d+/i })
 			.all()
-			.then((sections) =>
-				sections.map((section) => new QuestionSection(this.page, section)),
+			.then((items) =>
+				items.map((item) => new QuestionSection(this.page, item)),
 			)
 	}
 

playwright/support/sections/ResultsSection.ts

@@ -12,9 +12,11 @@ export class ResultsSection {
 	public readonly responseCount: Locator
 
 	constructor(public readonly page: Page) {
-		// PillMenu renders NcCheckboxRadioSwitch as radio buttons
-		this.summaryTab = this.page.getByRole('radio', { name: 'Summary' })
-		this.responsesTab = this.page.getByRole('radio', { name: 'Responses' })
+		// Scope to main content to avoid conflict with TopBar radios that have the same names.
+		// The PillMenu tabs are inside NcAppContent (main), the TopBar is in the navigation header.
+		const main = this.page.getByRole('main')
+		this.summaryTab = main.getByRole('radio', { name: 'Summary' })
+		this.responsesTab = main.getByRole('radio', { name: 'Responses' })
 		this.noResponsesMessage = this.page.getByText('No responses yet')
 		// Results.vue renders: "{amount} responses" in a <p> tag
 		this.responseCount = this.page.getByText(/\d+ responses?/)
@@ -33,8 +35,8 @@ export class ResultsSection {
 	 * ResultsSummary components render the question text as a heading.
 	 */
 	public getSummaryForQuestion(name: string | RegExp): Locator {
-		return this.page
-			.locator('section')
-			.filter({ has: this.page.getByRole('heading', { name }) })
+		// ResultsSummary renders as <div class="section question-summary"> with an <h3> inside.
+		// We locate the heading and return its parent element.
+		return this.page.getByRole('main').getByRole('heading', { name }).locator('..')
 	}
 }

playwright/support/sections/TopBarSection.ts

@@ -8,7 +8,8 @@ import type { Locator, Page } from '@playwright/test'
 export enum FormsView {
 	View = 'View',
 	Edit = 'Edit',
-	Results = 'Results',
+	// TopBar.vue labels this view "Responses" in the UI
+	Results = 'Responses',
 }
 
 export class TopBarSection {