From bda8bd9edabf5350635d7089ec0ff486e7389bb5 Mon Sep 17 00:00:00 2001
From: Ferdinand Thiessen <opensource@fthiessen.de>
Date: Tue, 19 May 2026 17:40:00 +0200
Subject: [PATCH] fix: email shares need to convert recipient for userid

`shareWith` of an email share is the email address.
But the email address is NOT always the userId.
So for that case we need to convert the email to the userId.

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
---
 lib/Listener/ShareCreatedListener.php | 18 +++++++++++-------
 1 file changed, 11 insertions(+), 7 deletions(-)

diff --git a/lib/Listener/ShareCreatedListener.php b/lib/Listener/ShareCreatedListener.php
index 6061f23f..1d57a30e 100644
--- a/lib/Listener/ShareCreatedListener.php
+++ b/lib/Listener/ShareCreatedListener.php
@@ -11,11 +11,11 @@
 namespace OCA\Guests\Listener;
 
 use OCA\Guests\AppInfo\Application;
+use OCA\Guests\Config;
 use OCA\Guests\GuestManager;
 use OCA\Guests\Service\InviteService;
 use OCP\EventDispatcher\Event;
 use OCP\EventDispatcher\IEventListener;
-use OCP\IUserManager;
 use OCP\IUserSession;
 use OCP\Share\Events\ShareCreatedEvent;
 use OCP\Share\IShare;
@@ -28,7 +28,7 @@ class ShareCreatedListener implements IEventListener {
 	public function __construct(
 		private readonly LoggerInterface $logger,
 		private readonly IUserSession $userSession,
-		private readonly IUserManager $userManager,
+		private readonly Config $config,
 		private readonly GuestManager $guestManager,
 		private readonly InviteService $inviteService,
 	) {
@@ -53,12 +53,16 @@ public function handle(Event $event): void {
 			return;
 		}
 
-		$shareWith = $share->getSharedWith();
+		$guestId = $share->getSharedWith();
+		if ($share->getShareType() === IShare::TYPE_EMAIL && $this->config->useHashedEmailAsUserID()) {
+			$email = strtolower($guestId);
+			$guestId = hash('sha256', $email);
+		}
 
-		$isGuest = $this->guestManager->isGuest($shareWith);
+		$isGuest = $this->guestManager->isGuest($guestId);
 		if (!$isGuest) {
 			$this->logger->debug(
-				"ignoring user '" . $shareWith . "', not a guest",
+				"ignoring user '" . $guestId . "', not a guest",
 				['app' => Application::APP_ID]
 			);
 			return;
@@ -80,11 +84,11 @@ public function handle(Event $event): void {
 			);
 		}
 
-		$this->logger->debug("checking if '" . $shareWith . "' has a password",
+		$this->logger->debug("checking if '" . $guestId . "' has a password",
 			['app' => Application::APP_ID]);
 
 		$uid = $user->getUID();
 
-		$this->inviteService->sendInvite($uid, $shareWith, $share);
+		$this->inviteService->sendInvite($uid, $guestId, $share);
 	}
 }