fix: Allow to write default values so we know if the folder has been set manually

Signed-off-by: Julius Härtl <jus@bitgrid.net>

Author: juliusknorr

lib/Service/NoteUtil.php

@@ -204,7 +204,7 @@ public function getOrCreateNotesFolder(string $userId, bool $create = true) : Fo
 		if ($updateNotesPath) {
 			$this->settingsService->set($userId, [
 				'notesPath' => $notesPath,
-			]);
+			], true);
 		}
 
 		return $folder;

lib/Service/SettingsService.php

@@ -94,7 +94,7 @@ public function getDefaultNotesPath(string $uid) : string {
 	/**
 	 * @throws \OCP\PreConditionNotMetException
 	 */
-	public function set(string $uid, array $settings) : void {
+	public function set(string $uid, array $settings, bool $writeDefaults = false) : void {
 		// load existing values for missing attributes
 		$oldSettings = $this->getSettingsFromDB($uid);
 		foreach ($oldSettings as $name => $value) {
@@ -108,10 +108,10 @@ public function set(string $uid, array $settings) : void {
 				$settings[$name] = $value = $this->attrs[$name]['validate']($value);
 			}
 			$default = is_callable($this->attrs[$name]['default']) ? $this->attrs[$name]['default']($uid) : $this->attrs[$name]['default'];
-			if (!array_key_exists($name, $this->attrs)
+			if (!$writeDefaults && (!array_key_exists($name, $this->attrs)
 				|| $value === null
 				|| $value === $default
-			) {
+			)) {
 				unset($settings[$name]);
 			}
 		}