Fix closebutton clicks and improve wait conditions across all test files

Co-authored-by: juliusknorr <3404133+juliusknorr@users.noreply.github.com>

Author: Claude

cypress/e2e/integration.spec.js

@@ -75,17 +75,17 @@ describe('Nextcloud integration', function() {
 				.should('be.visible')
 
 			cy.get('button[aria-label="File"]').click()
-			cy.get('button[aria-label="Save As"]')
-				.should('be.visible', { timeout: 10_000 })
+			cy.get('button[aria-label="Save As"]', { timeout: 10_000 })
+				.should('be.visible')
 				.click()
 
-			cy.get('#saveas-entries > div')
+			cy.get('#saveas-entries > div', { timeout: 10_000 })
 				.contains('Rich Text (.rtf)')
 				.should('be.visible')
 				.click()
 		})
 
-		cy.get('.saveas-dialog').should('be.visible')
+		cy.get('.saveas-dialog', { timeout: 10_000 }).should('be.visible')
 		cy.get('.saveas-dialog input[type=text]')
 			.should('be.visible')
 			.should('have.value', `/${exportFilename}`)
@@ -96,9 +96,9 @@ describe('Nextcloud integration', function() {
 		cy.waitForPostMessage('Action_Save_Resp', { success: true, fileName: exportFilename })
 
 		cy.get('@loleafletframe').within(() => {
-			cy.get('#closebutton').click()
-			cy.waitForViewerClose()
+			cy.get('#closebutton', { timeout: 10000 }).should('be.visible').click()
 		})
+		cy.waitForViewerClose()
 
 		cy.openFile(exportFilename)
 	})

cypress/e2e/share-federated.spec.js

@@ -34,9 +34,9 @@ describe('Federated sharing of office documents', function() {
 		cy.openFile(filename)
 		cy.waitForViewer()
 		cy.waitForCollabora(true, true).within(() => {
-			cy.get('#closebutton').click()
-			cy.waitForViewerClose()
+			cy.get('#closebutton', { timeout: 10000 }).should('be.visible').click()
 		})
+		cy.waitForViewerClose()
 	})
 
 	it.skip('Open a remotely shared file as a link', function() {
@@ -80,9 +80,9 @@ describe('Federated sharing of office documents', function() {
 				cy.openFile(filename)
 				cy.waitForViewer()
 				cy.waitForCollabora(true, true).within(() => {
-					cy.get('#closebutton').click()
-					cy.waitForViewerClose()
+					cy.get('#closebutton', { timeout: 10000 }).should('be.visible').click()
 				})
+				cy.waitForViewerClose()
 			})
 		})
 	})

cypress/e2e/share-internal.spec.js

@@ -37,9 +37,9 @@ describe('File sharing of office documents', function() {
 
 		// Validate closing
 		cy.get('@loleafletframe').within(() => {
-			cy.get('#closebutton').click()
-			cy.waitForViewerClose()
+			cy.get('#closebutton', { timeout: 10000 }).should('be.visible').click()
 		})
+		cy.waitForViewerClose()
 	})
 
 	it('Open a shared file as readonly', function() {
@@ -60,8 +60,8 @@ describe('File sharing of office documents', function() {
 
 		// Validate closing
 		cy.get('@loleafletframe').within(() => {
-			cy.get('#closebutton').click()
-			cy.waitForViewerClose()
+			cy.get('#closebutton', { timeout: 10000 }).should('be.visible').click()
 		})
+		cy.waitForViewerClose()
 	})
 })

cypress/e2e/share-link.js

@@ -145,7 +145,7 @@ function waitForCollabora() {
 	cy.waitForPostMessage('App_LoadingStatus', { Status: 'Document_Loaded' })
 
 	cy.get('@loleafletframe').within(() => {
-		cy.get('#closebutton').click()
-		cy.waitForViewerClose()
+		cy.get('#closebutton', { timeout: 10000 }).should('be.visible').click()
 	})
+	cy.waitForViewerClose()
 }