External storages gets duplicated when login changes

[come-nc]

This issue has to do with external storages like SMB, SFTP, FTP…

They can be configured to use credentials from the user, stored either in session or in DB.
They use the login and other parameter as part of the ID, so that different user get a different storage. But that cause an issue when the login of a user changes. This can happen when LDAP is used as a backend for instance, or when allowing email as well as login.

My first impulse to fix that was to use the user ID instead of the user login in the storage id. But the issue with that is that in some cases we want users to access the same global storage, and in this case it has the same id on purpose.

I guess we could use the user id instead of login only when using mechanism like "Log-in credentials, save in database".
But we could have the same issue with global credentials, if the login changes and the admin reconfigure it, it should not change id and lose metadata I suppose?

[salmart-dev]

This is actually not only relevant for the user ID, but any storage which stores the server's address or the root for the mount as part of the storage ID, causes storage entries to be left over indefinitely. By looking at the code there is no way to remove those (if not by hand in the DB) and also no easy fix.