From ef4c18a266804d13f8e8bd0efe26cda17e3d99af Mon Sep 17 00:00:00 2001 From: Christoph Wurst Date: Tue, 22 Feb 2022 11:31:54 +0100 Subject: [PATCH] Deprecate our old, internal background job base classes The OCP ones should be used instead. This makes it more visible in our IDEs that the base class of background job should be replaced. Signed-off-by: Christoph Wurst --- lib/private/BackgroundJob/Job.php | 3 +++ lib/private/BackgroundJob/Legacy/QueuedJob.php | 3 +++ lib/private/BackgroundJob/Legacy/RegularJob.php | 3 +++ lib/private/BackgroundJob/QueuedJob.php | 2 ++ lib/private/BackgroundJob/TimedJob.php | 2 ++ 5 files changed, 13 insertions(+) diff --git a/lib/private/BackgroundJob/Job.php b/lib/private/BackgroundJob/Job.php index 6f85e3382ed94..399ff05134e71 100644 --- a/lib/private/BackgroundJob/Job.php +++ b/lib/private/BackgroundJob/Job.php @@ -29,6 +29,9 @@ use OCP\BackgroundJob\IJobList; use OCP\ILogger; +/** + * @deprecated internal class, use \OCP\BackgroundJob\Job + */ abstract class Job implements IJob { /** @var int */ protected $id; diff --git a/lib/private/BackgroundJob/Legacy/QueuedJob.php b/lib/private/BackgroundJob/Legacy/QueuedJob.php index d68fd217fdd87..fd001738d4fa1 100644 --- a/lib/private/BackgroundJob/Legacy/QueuedJob.php +++ b/lib/private/BackgroundJob/Legacy/QueuedJob.php @@ -23,6 +23,9 @@ */ namespace OC\BackgroundJob\Legacy; +/** + * @deprecated internal class, use \OCP\BackgroundJob\QueuedJob + */ class QueuedJob extends \OC\BackgroundJob\QueuedJob { public function run($argument) { $class = $argument['klass']; diff --git a/lib/private/BackgroundJob/Legacy/RegularJob.php b/lib/private/BackgroundJob/Legacy/RegularJob.php index e3286536c9a3d..0f337a35eb0ad 100644 --- a/lib/private/BackgroundJob/Legacy/RegularJob.php +++ b/lib/private/BackgroundJob/Legacy/RegularJob.php @@ -24,6 +24,9 @@ use OCP\AutoloadNotAllowedException; +/** + * @deprecated internal class, use \OCP\BackgroundJob\QueuedJob + */ class RegularJob extends \OC\BackgroundJob\Job { public function run($argument) { try { diff --git a/lib/private/BackgroundJob/QueuedJob.php b/lib/private/BackgroundJob/QueuedJob.php index 176227e73dbbb..28d86481e6276 100644 --- a/lib/private/BackgroundJob/QueuedJob.php +++ b/lib/private/BackgroundJob/QueuedJob.php @@ -32,6 +32,8 @@ * create a background job that is to be executed once * * @package OC\BackgroundJob + * + * @deprecated internal class, use \OCP\BackgroundJob\QueuedJob */ abstract class QueuedJob extends Job { /** diff --git a/lib/private/BackgroundJob/TimedJob.php b/lib/private/BackgroundJob/TimedJob.php index 62b9bab7ccc0a..0f0951e1aec6f 100644 --- a/lib/private/BackgroundJob/TimedJob.php +++ b/lib/private/BackgroundJob/TimedJob.php @@ -34,6 +34,8 @@ * create a background job that is to be executed at an interval * * @package OC\BackgroundJob + * + * @deprecated internal class, use \OCP\BackgroundJob\TimedJob */ abstract class TimedJob extends Job { protected $interval = 0;