Skip to content

Commit 2d5439c

Browse files
Merge pull request #2432 from nextcloud/renovate/main-shivammathur-setup-php-digest
chore(deps): update shivammathur/setup-php digest to accd612 (main)
2 parents 6a13bd7 + 024c8a1 commit 2d5439c

3 files changed

Lines changed: 12 additions & 3 deletions

File tree

.github/workflows/app-upgrade-mysql.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -94,7 +94,7 @@ jobs:
9494
ref: ${{ matrix.server-versions }}
9595

9696
- name: Set up php ${{ matrix.php-versions }}
97-
uses: shivammathur/setup-php@bf6b4fbd49ca58e4608c9c89fba0b8d90bd2a39f # v2
97+
uses: shivammathur/setup-php@accd6127cb78bee3e8082180cb391013d204ef9f # v2
9898
with:
9999
php-version: ${{ matrix.php-versions }}
100100
# https://docs.nextcloud.com/server/stable/admin_manual/installation/source_installation.html#prerequisites-for-manual-installation

.github/workflows/psalm-matrix-custom.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,7 @@ jobs:
2929
uses: actions/checkout@34e114876b0b11c390a56381ad16ebd13914f8d5 # v4.3.1
3030

3131
- name: Set up php8.2
32-
uses: shivammathur/setup-php@bf6b4fbd49ca58e4608c9c89fba0b8d90bd2a39f # v2
32+
uses: shivammathur/setup-php@accd6127cb78bee3e8082180cb391013d204ef9f # v2
3333
with:
3434
php-version: 8.2
3535
extensions: bz2, ctype, curl, dom, fileinfo, gd, iconv, intl, json, libxml, mbstring, openssl, pcntl, posix, session, simplexml, xmlreader, xmlwriter, zip, zlib, sqlite, pdo_sqlite

cypress/e2e/view-filtering-selection-row-removal.cy.js

Lines changed: 10 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -28,6 +28,7 @@ describe('Filtering in a view by selection columns (Cypress supplement – row r
2828
cy.fillInValueSelectionMulti('multi selection', ['A', 'B'])
2929
cy.fillInValueSelectionCheck('check')
3030
cy.get('[data-cy="createRowSaveButton"]').click()
31+
cy.get('[data-cy="createRowModal"]').should('not.exist')
3132

3233
// add row
3334
cy.get('[data-cy="createRowBtn"]').click()
@@ -36,20 +37,23 @@ describe('Filtering in a view by selection columns (Cypress supplement – row r
3637
cy.fillInValueSelectionMulti('multi selection', ['B'])
3738
cy.fillInValueSelectionCheck('check')
3839
cy.get('[data-cy="createRowSaveButton"]').click()
40+
cy.get('[data-cy="createRowModal"]').should('not.exist')
3941

4042
// add row
4143
cy.get('[data-cy="createRowBtn"]').click()
4244
cy.fillInValueTextLine('title', 'third row')
4345
cy.fillInValueSelection('selection', 'sel3')
4446
cy.fillInValueSelectionMulti('multi selection', ['C', 'B', 'D'])
4547
cy.get('[data-cy="createRowSaveButton"]').click()
48+
cy.get('[data-cy="createRowModal"]').should('not.exist')
4649

4750
// add row
4851
cy.get('[data-cy="createRowBtn"]').click()
4952
cy.fillInValueTextLine('title', 'fourth row')
5053
cy.fillInValueSelectionMulti('multi selection', ['A'])
5154
cy.fillInValueSelectionCheck('check')
5255
cy.get('[data-cy="createRowSaveButton"]').click()
56+
cy.get('[data-cy="createRowModal"]').should('not.exist')
5357

5458
// add row
5559
cy.get('[data-cy="createRowBtn"]').click()
@@ -58,6 +62,7 @@ describe('Filtering in a view by selection columns (Cypress supplement – row r
5862
cy.fillInValueSelectionMulti('multi selection', ['D'])
5963
cy.fillInValueSelectionCheck('check')
6064
cy.get('[data-cy="createRowSaveButton"]').click()
65+
cy.get('[data-cy="createRowModal"]').should('not.exist')
6166

6267
// add row
6368
cy.get('[data-cy="createRowBtn"]').click()
@@ -66,13 +71,15 @@ describe('Filtering in a view by selection columns (Cypress supplement – row r
6671
cy.fillInValueSelectionMulti('multi selection', ['C', 'D'])
6772
cy.fillInValueSelectionCheck('check')
6873
cy.get('[data-cy="createRowSaveButton"]').click()
74+
cy.get('[data-cy="createRowModal"]').should('not.exist')
6975

7076
// add row
7177
cy.get('[data-cy="createRowBtn"]').click()
7278
cy.fillInValueTextLine('title', 'sevenths row')
7379
cy.fillInValueSelection('selection', 'sel2')
7480
cy.fillInValueSelectionMulti('multi selection', ['A', 'C', 'B', 'D'])
7581
cy.get('[data-cy="createRowSaveButton"]').click()
82+
cy.get('[data-cy="createRowModal"]').should('not.exist')
7683

7784
cy.loadTable('View filtering test table')
7885
})
@@ -116,6 +123,7 @@ describe('Filtering in a view by selection columns (Cypress supplement – row r
116123

117124
// ## check if row is visible
118125
cy.contains('[data-cy="ncTable"] [data-cy="customTableRow"]', 'checked row').should('be.visible')
126+
cy.get('[data-cy="createRowModal"]').should('not.exist')
119127

120128
// # insert a unchecked row
121129
cy.get('[data-cy="createRowBtn"]').click()
@@ -130,6 +138,7 @@ describe('Filtering in a view by selection columns (Cypress supplement – row r
130138

131139
// ## check if row does not exist
132140
cy.contains('[data-cy="ncTable"] [data-cy="customTableRow"]', 'unchecked row').should('not.exist')
141+
cy.get('[data-cy="createRowModal"]').should('not.exist')
133142

134143
// # edit checked row
135144
// ## uncheck
@@ -145,6 +154,7 @@ describe('Filtering in a view by selection columns (Cypress supplement – row r
145154

146155
// ## check if row does not exist
147156
cy.contains('[data-cy="ncTable"] [data-cy="customTableRow"]', 'checked row').should('not.exist')
157+
cy.get('[data-cy="editRowModal"]').should('not.exist')
148158

149159
// # inline edit row
150160
// ## uncheck row
@@ -153,7 +163,6 @@ describe('Filtering in a view by selection columns (Cypress supplement – row r
153163

154164
// ## check server response for /view/{viewId}/row/{id}/present
155165
cy.wait('@isRowInViewPresent').then(({ response: { body: { present } } }) => {
156-
cy.wait(1000)
157166
expect(present).to.equal(false)
158167
})
159168

0 commit comments

Comments
 (0)