Display Utils customization extracted out.

Author: surinder-tsys

app/src/main/java/com/nextcloud/client/onboarding/FirstRunActivity.java

@@ -85,7 +85,7 @@ protected void onCreate(Bundle savedInstanceState) {
 
         //if device is not tablet then we have to lock it to Portrait mode
         //as we don't have images for that
-        if (!DisplayUtils.isTablet()) {
+        if (!com.nmc.android.utils.DisplayUtils.isTablet()) {
             setRequestedOrientation(ActivityInfo.SCREEN_ORIENTATION_PORTRAIT);
         }
 
@@ -123,7 +123,7 @@ private void updateOnBoardingPager(int selectedPosition) {
     }
 
     private void updateLoginButtonMargin() {
-        if (DisplayUtils.isLandscapeOrientation()) {
+        if (com.nmc.android.utils.DisplayUtils.isLandscapeOrientation()) {
             if (binding.login.getLayoutParams() instanceof ViewGroup.MarginLayoutParams) {
                 ((ViewGroup.MarginLayoutParams) binding.login.getLayoutParams()).setMargins(
                     0, 0, 0, getResources().getDimensionPixelOffset(

app/src/main/java/com/nmc/android/helper/OnBoardingPagerAdapter.kt

@@ -35,7 +35,7 @@ class OnBoardingPagerAdapter(val context: Context, val items: List<FeatureItem>)
 
         //due to cropping of image in landscape mode we are using fix xy for landscape and
         //center crop for other
-        if (DisplayUtils.isLandscapeOrientation()) {
+        if (com.nmc.android.utils.DisplayUtils.isLandscapeOrientation()) {
             binding.ivOnboarding.scaleType = ImageView.ScaleType.FIT_XY
         } else {
             binding.ivOnboarding.scaleType = ImageView.ScaleType.CENTER_CROP

app/src/main/java/com/nmc/android/helper/OnBoardingUtils.kt

@@ -34,8 +34,8 @@ class OnBoardingUtils {
         }
 
         private fun getOnBoardingImages(): Array<Int> {
-            return if (DisplayUtils.isTablet()) {
-                if (DisplayUtils.isLandscapeOrientation()) {
+            return if (com.nmc.android.utils.DisplayUtils.isTablet()) {
+                if (com.nmc.android.utils.DisplayUtils.isLandscapeOrientation()) {
                     TAB_LAND_IMAGES
                 } else {
                     TAB_PORT_IMAGES

app/src/main/java/com/nmc/android/utils/DisplayUtils.kt

@@ -0,0 +1,18 @@
+package com.nmc.android.utils
+
+import android.content.res.Configuration
+import com.owncloud.android.MainApp
+import com.owncloud.android.R
+
+object DisplayUtils {
+
+    @JvmStatic
+    fun isShowDividerForList(): Boolean = isTablet() || isLandscapeOrientation()
+
+    @JvmStatic
+    fun isTablet(): Boolean = MainApp.getAppContext().resources.getBoolean(R.bool.isTablet)
+
+    @JvmStatic
+    fun isLandscapeOrientation(): Boolean =
+        MainApp.getAppContext().resources.configuration.orientation == Configuration.ORIENTATION_LANDSCAPE
+}

app/src/main/java/com/owncloud/android/utils/DisplayUtils.java

@@ -32,7 +32,6 @@
 import android.app.Activity;
 import android.content.Context;
 import android.content.Intent;
-import android.content.res.Configuration;
 import android.content.res.Resources;
 import android.graphics.Bitmap;
 import android.graphics.Color;
@@ -1005,13 +1004,4 @@ private static Point getScreenSize(Context context) throws Exception {
             throw new Exception("WindowManager not found");
         }
     }
-
-    public static boolean isTablet() {
-        return MainApp.getAppContext().getResources().getBoolean(R.bool.isTablet);
-    }
-
-    public static boolean isLandscapeOrientation() {
-        return MainApp.getAppContext().getResources().getConfiguration().orientation == Configuration.ORIENTATION_LANDSCAPE;
-    }
-
 }