Skip to content

Commit b597c27

Browse files
Fixed name, soname, and version of the C++ bindings
1 parent 040d93d commit b597c27

1 file changed

Lines changed: 6 additions & 19 deletions

File tree

bindings/cpp/CMakeLists.txt

Lines changed: 6 additions & 19 deletions
Original file line numberDiff line numberDiff line change
@@ -38,28 +38,18 @@ set_property(SOURCE ${SOURCES} APPEND PROPERTY COMPILE_FLAGS ${NX_CFLAGS})
3838
#------------------------------------------------------------------------------
3939
add_library (NeXus_CPP_Static_Library STATIC ${HEADERS} ${SOURCES})
4040
set_target_properties(NeXus_CPP_Static_Library PROPERTIES
41-
OUTPUT_NAME NeXusCPPStatic)
41+
OUTPUT_NAME NeXusCPP)
4242

43-
target_link_libraries(NeXus_CPP_Static_Library NeXus_Static_Library
44-
${READLINE_LINK} ${M_LINK} ${DL_LINK} ${PTHREAD_LINK} ${DF_LINK}
45-
${TERMCAP_LINK} ${HISTORY_LINK} ${JPEG_LIBRARIES} ${ZLIB_LIBRARIES})
43+
target_link_libraries(NeXus_CPP_Static_Library NeXus_Static_Library)
4644

4745
#Make NeXus CPP Bindings Shared Library
4846
#------------------------------------------------------------------------------
4947
add_library (NeXus_CPP_Shared_Library SHARED ${HEADERS} ${SOURCES})
50-
51-
#Note - library version needs to be got from somewhere?
52-
# may want to use DEBUG_OUTPUT_NAME and RELEASE_OUTPUT_NAME
53-
# of define CMAKE_DEBUG_POSTFIX globally
54-
if(${CMAKE_SYSTEM_NAME} MATCHES "Windows")
55-
set_target_properties(NeXus_CPP_Shared_Library PROPERTIES OUTPUT_NAME libNeXusCPP-0
56-
VERSION 1.0 SOVERSION 4 )
57-
else(${CMAKE_SYSTEM_NAME} MATCHES "Windows")
58-
set_target_properties(NeXus_CPP_Shared_Library PROPERTIES OUTPUT_NAME NeXusCPP
59-
VERSION 1.0 SOVERSION 4)
60-
endif (${CMAKE_SYSTEM_NAME} MATCHES "Windows")
61-
6248
target_link_libraries(NeXus_CPP_Shared_Library NeXus_Shared_Library)
49+
set_target_properties(NeXus_CPP_Shared_Library PROPERTIES
50+
OUTPUT_NAME NeXusCPP
51+
VERSION "${NAPI_VERSION}"
52+
SOVERSION ${NEXUS_SONAME})
6353

6454
install (TARGETS NeXus_CPP_Static_Library NeXus_CPP_Shared_Library
6555
DESTINATION ${CMAKE_INSTALL_LIBDIR}
@@ -68,9 +58,6 @@ install (TARGETS NeXus_CPP_Static_Library NeXus_CPP_Shared_Library
6858
INSTALL (FILES ${HEADERS} DESTINATION ${CMAKE_INSTALL_INCLUDEDIR}
6959
COMPONENT Development)
7060

71-
#if(WIN32)
72-
#install_pdb (NeXus_CPP_Shared_Library)
73-
#endif()
7461

7562

7663

0 commit comments

Comments
 (0)