Skip to content

Commit 0fadeb7

Browse files
committed
0.9.0.48: Replaced assorted magic numbers for view switching with named global constants, fixed bug where view grid view button would enable in edit mode if you imported a CEDB database while viewing and editing a table
1 parent 77e52f8 commit 0fadeb7

5 files changed

Lines changed: 12 additions & 8 deletions

File tree

src/sqlite-ce-edit/execute.c

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -280,7 +280,7 @@ void ExecuteSQL(const char *sql) {
280280
/* Switch to results */
281281
if (g_gridView && g_hwndGrid)
282282
SendMessage(g_hwndGrid, WM_SETREDRAW, FALSE, 0);
283-
SwitchView(1);
283+
SwitchView(VIEW_RESULT);
284284
SendMessage(g_hwndCB, TB_CHECKBUTTON, IDM_VIEWQUERY, FALSE);
285285
SendMessage(g_hwndCB, TB_CHECKBUTTON, IDM_VIEWRESULT, TRUE);
286286
SendMessage(g_hwndCB, TB_CHECKBUTTON, IDM_VIEWSCHEMA, FALSE);
@@ -648,7 +648,7 @@ void ExecuteQuery(void) {
648648
/* Suppress redraw during view switch to avoid flicker */
649649
if (g_gridView && g_hwndGrid)
650650
SendMessage(g_hwndGrid, WM_SETREDRAW, FALSE, 0);
651-
SwitchView(1);
651+
SwitchView(VIEW_RESULT);
652652
SendMessage(g_hwndCB, TB_CHECKBUTTON, IDM_VIEWQUERY, FALSE);
653653
SendMessage(g_hwndCB, TB_CHECKBUTTON, IDM_VIEWRESULT, TRUE);
654654
SendMessage(g_hwndCB, TB_CHECKBUTTON, IDM_VIEWSCHEMA, FALSE);

src/sqlite-ce-edit/globals.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -87,7 +87,7 @@ BOOL WINAPI GetSaveFileNameW(CE_OPENFILENAME*);
8787
** Version
8888
**============================================================================*/
8989

90-
#define SQLITECEDIT_VERSION L"0.9.0.46"
90+
#define SQLITECEDIT_VERSION L"0.9.0.48"
9191

9292
/*============================================================================
9393
** Menu IDs

src/sqlite-ce-edit/import.c

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -553,9 +553,13 @@ void DoImportCEDB(void) {
553553
OutputLine(msg);
554554
}
555555
FlushOutput();
556-
SwitchView(1);
556+
ClearEditMode();
557+
g_lastResultRows = 0;
558+
SwitchView(VIEW_RESULT);
557559
SendMessage(g_hwndCB, TB_CHECKBUTTON, IDM_VIEWQUERY, FALSE);
558560
SendMessage(g_hwndCB, TB_CHECKBUTTON, IDM_VIEWRESULT, TRUE);
561+
SendMessage(g_hwndCB, TB_CHECKBUTTON, IDM_VIEWSCHEMA, FALSE);
562+
SendMessage(g_hwndCB, TB_ENABLEBUTTON, IDM_EXECATCURSOR, FALSE);
559563

560564
cleanup:
561565
for (i = 0; i < dbCount; i++) {

src/sqlite-ce-edit/main.c

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -341,21 +341,21 @@ static LRESULT CALLBACK WndProc(HWND hwnd, UINT msg, WPARAM wParam, LPARAM lPara
341341
DoOptions();
342342
break;
343343
case IDM_VIEWQUERY:
344-
SwitchView(0);
344+
SwitchView(VIEW_QUERY);
345345
SendMessage(g_hwndCB, TB_CHECKBUTTON, IDM_VIEWQUERY, TRUE);
346346
SendMessage(g_hwndCB, TB_CHECKBUTTON, IDM_VIEWRESULT, FALSE);
347347
SendMessage(g_hwndCB, TB_CHECKBUTTON, IDM_VIEWSCHEMA, FALSE);
348348
CheckMenuRadioItem(g_hViewMenu, IDM_VIEWQUERY, IDM_VIEWSCHEMA, IDM_VIEWQUERY, MF_BYCOMMAND);
349349
break;
350350
case IDM_VIEWRESULT:
351-
SwitchView(1);
351+
SwitchView(VIEW_RESULT);
352352
SendMessage(g_hwndCB, TB_CHECKBUTTON, IDM_VIEWQUERY, FALSE);
353353
SendMessage(g_hwndCB, TB_CHECKBUTTON, IDM_VIEWRESULT, TRUE);
354354
SendMessage(g_hwndCB, TB_CHECKBUTTON, IDM_VIEWSCHEMA, FALSE);
355355
CheckMenuRadioItem(g_hViewMenu, IDM_VIEWQUERY, IDM_VIEWSCHEMA, IDM_VIEWRESULT, MF_BYCOMMAND);
356356
break;
357357
case IDM_VIEWSCHEMA:
358-
SwitchView(2);
358+
SwitchView(VIEW_SCHEMA);
359359
SendMessage(g_hwndCB, TB_CHECKBUTTON, IDM_VIEWQUERY, FALSE);
360360
SendMessage(g_hwndCB, TB_CHECKBUTTON, IDM_VIEWRESULT, FALSE);
361361
SendMessage(g_hwndCB, TB_CHECKBUTTON, IDM_VIEWSCHEMA, TRUE);

src/sqlite-ce-edit/schema.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -531,7 +531,7 @@ void OpenTableForEditing(const char *tablename) {
531531
/* Populate grid and switch to grid view */
532532
g_gridView = 1;
533533
PopulateGrid();
534-
SwitchView(1);
534+
SwitchView(VIEW_RESULT);
535535
SendMessage(g_hwndCB, TB_CHECKBUTTON, IDM_VIEWQUERY, FALSE);
536536
SendMessage(g_hwndCB, TB_CHECKBUTTON, IDM_VIEWRESULT, TRUE);
537537
SendMessage(g_hwndCB, TB_CHECKBUTTON, IDM_VIEWSCHEMA, FALSE);

0 commit comments

Comments
 (0)