0.10.0.59: Removed query editor Undo pending full re-implementation, standard CE 2.0 implementation appears insufficient

Author: nfinit

src/sqlite-ce-edit/editor.c

@@ -433,8 +433,8 @@ LRESULT CALLBACK QueryEditProc(HWND hwnd, UINT msg, WPARAM wParam, LPARAM lParam
             SendMessage(hwnd, EM_SCROLLCARET, 0, 0);
             return 0;
         }
-        /* Ctrl+C/V/X/Z - pass through for edit operations */
-        if (ctrl && (wParam == 'C' || wParam == 'V' || wParam == 'X' || wParam == 'Z'))
+        /* Ctrl+C/V/X - pass through for edit operations */
+        if (ctrl && (wParam == 'C' || wParam == 'V' || wParam == 'X'))
             return CallWindowProc(g_pfnQueryProc, hwnd, msg, wParam, lParam);
     }
     /* Update line count on keyup and scroll caret into view for navigation keys */
@@ -464,8 +464,8 @@ LRESULT CALLBACK QueryEditProc(HWND hwnd, UINT msg, WPARAM wParam, LPARAM lParam
                 UpdateLineNumbers();
                 return r;
             }
-            /* Ctrl+C=3, Ctrl+X=24, Ctrl+Z=26 - pass through */
-            if (wParam == 3 || wParam == 24 || wParam == 26)
+            /* Ctrl+C=3, Ctrl+X=24 - pass through */
+            if (wParam == 3 || wParam == 24)
                 return CallWindowProc(g_pfnQueryProc, hwnd, msg, wParam, lParam);
             return 0;
         }

src/sqlite-ce-edit/globals.h

@@ -87,7 +87,7 @@ BOOL WINAPI GetSaveFileNameW(CE_OPENFILENAME*);
 ** Version
 **============================================================================*/
 
-#define SQLITECEDIT_VERSION L"0.10.0.56"
+#define SQLITECEDIT_VERSION L"0.10.0.59"
 
 /*============================================================================
 ** Menu IDs

src/sqlite-ce-edit/main.c

@@ -407,9 +407,8 @@ static LRESULT CALLBACK WndProc(HWND hwnd, UINT msg, WPARAM wParam, LPARAM lPara
                     break;
                 /* Edit menu */
                 case IDM_UNDO:
-                    if (g_viewMode == VIEW_QUERY)
-                        SendMessage(g_hwndQuery, EM_UNDO, 0, 0);
-                    else if (g_editMode && CanUndo())
+                    /* Query editor undo disabled - CE Edit control is unreliable */
+                    if (g_editMode && CanUndo())
                         DoUndo();
                     break;
                 case IDM_CUT:
@@ -591,9 +590,8 @@ static LRESULT CALLBACK WndProc(HWND hwnd, UINT msg, WPARAM wParam, LPARAM lPara
                 int canUndo = 0;
                 int hasSelection = 0;
                 int canCut = (g_viewMode == VIEW_QUERY);
-                if (g_viewMode == VIEW_QUERY)
-                    canUndo = SendMessage(g_hwndQuery, EM_CANUNDO, 0, 0);
-                else if (g_editMode)
+                /* Query editor undo disabled - only grid row delete undo */
+                if (g_editMode)
                     canUndo = CanUndo();
                 if (g_viewMode == VIEW_RESULT && g_gridView && g_hwndGrid)
                     hasSelection = ListView_GetNextItem(g_hwndGrid, -1, LVNI_SELECTED) >= 0;