Skip to content

Commit dd20aa7

Browse files
committed
Correct some cppcheck warning
1 parent 08e9c32 commit dd20aa7

1 file changed

Lines changed: 3 additions & 3 deletions

File tree

src/lmic/lmicdynamicchannel.h

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,7 @@ class DynamicRegionalChannelParams : public RegionalChannelParams {
3434

3535
public:
3636
bool setupChannel(uint8_t const chidx, uint32_t const newfreq,
37-
uint16_t const drmap) {
37+
uint16_t const drmap) override {
3838
if (chidx >= channels.LIMIT_CHANNELS)
3939
return false;
4040

@@ -307,7 +307,7 @@ class DynamicRegionalChannelParams : public RegionalChannelParams {
307307
};
308308
#endif
309309

310-
DynamicRegionalChannelParams(LmicRand &arand) : rand{arand} {};
310+
explicit DynamicRegionalChannelParams(LmicRand &arand) : rand{arand} {};
311311

312312
protected:
313313
void setRegionalDutyCycleVerification(bool enabled) final {
@@ -328,7 +328,7 @@ class DynamicRegionalChannelParams : public RegionalChannelParams {
328328
uint8_t rx1DrOffset = 0;
329329
// Number of join requests sent
330330
uint8_t joinCount = 0;
331-
TransmitionParameters rx2Parameter;
331+
TransmitionParameters rx2Parameter = {default_Freq_RX2, rps_t(default_rps_RX2), 0};
332332

333333
private:
334334
dr_t getRx1Dr() const { return lowerDR(datarate, rx1DrOffset); };

0 commit comments

Comments
 (0)