Skip to content

Commit 46c803b

Browse files
authored
Update repo for changes in measurement.proto (#100)
* Updated stubs - tests are passing * Remove unused import
1 parent c299f76 commit 46c803b

13 files changed

Lines changed: 329 additions & 763 deletions

File tree

ni_measurement_service/_internal/grpc_servicer.py

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -154,16 +154,15 @@ def GetMetadata(self, request, context): # noqa N802:inherited method names-aut
154154
# User Interface details - Framed relative to the metadata python File
155155
ui_details = Measurement_pb2.UserInterfaceDetails()
156156

157-
ui_details.configuration_ui_url = (
158-
self.measurement_info.ui_file_type.value + self.measurement_info.ui_file_path
159-
)
157+
ui_details.configuration_ui_url = self.measurement_info.ui_file_path
160158

161159
# Sending back Response
162160
metadata_response = Measurement_pb2.GetMetadataResponse(
163161
measurement_details=measurement_details,
164162
measurement_parameters=measurement_parameters,
165-
user_interface_details=ui_details,
163+
user_interface_details=None,
166164
)
165+
metadata_response.user_interface_details.append(ui_details)
167166
return metadata_response
168167

169168
def Measure(self, request, context): # noqa N802:inherited method names-autogen baseclass

ni_measurement_service/_internal/stubs/Measurement_pb2.py

Lines changed: 47 additions & 23 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

ni_measurement_service/_internal/stubs/ServiceManagement_pb2_grpc.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22
"""Client and server classes corresponding to protobuf-defined services."""
33
import grpc
44

5-
from . import ServiceManagement_pb2 as ServiceManagement__pb2
5+
import ServiceManagement_pb2 as ServiceManagement__pb2
66

77

88
class ServiceManagementServiceStub(object):
Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,2 +1,2 @@
1-
poetry run python -m grpc_tools.protoc -I proto --python_out=. --grpc_python_out=. ServiceLocation.proto DiscoveryServices.proto Measurement.proto ServiceManagement.proto && ^
1+
poetry run python -m grpc_tools.protoc -I proto --python_out=. --grpc_python_out=. proto/ni/measurements/pin_map_context.proto ServiceLocation.proto DiscoveryServices.proto Measurement.proto ServiceManagement.proto && ^
22
poetry run black *.py
Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1 @@
1+
""" Auto generated gRPC files."""
Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1 @@
1+
""" Auto generated gRPC files."""

ni_measurement_service/_internal/stubs/ni/measurements/pin_map_context_pb2.py

Lines changed: 78 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.
Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,4 @@
1+
# Generated by the gRPC Python protocol compiler plugin. DO NOT EDIT!
2+
"""Client and server classes corresponding to protobuf-defined services."""
3+
import grpc
4+

ni_measurement_service/_internal/stubs/proto/Measurement.proto

Lines changed: 8 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -14,15 +14,16 @@ option csharp_namespace = "NationalInstruments.MeasurementServices.Measurements"
1414
//---------------------------------------------------------------------
1515
import "google/protobuf/any.proto";
1616
import "google/protobuf/type.proto";
17+
import "ni/measurements/pin_map_context.proto";
1718

1819
// Service that contains methods related to measurement
1920
service MeasurementService {
20-
21+
2122
// API to get complete metadata
2223
rpc GetMetadata (GetMetadataRequest) returns (GetMetadataResponse);
23-
24+
2425
// API to measure
25-
rpc Measure (MeasureRequest) returns (MeasureResponse);
26+
rpc Measure (MeasureRequest) returns (MeasureResponse);
2627
}
2728

2829
// Below message is the metadata request which is currently empty
@@ -84,9 +85,9 @@ message GetMetadataResponse{
8485

8586
// Measurement Configurations and outputs details
8687
MeasurementParameters measurement_parameters = 2;
87-
88+
8889
// Measurement User Interface details
89-
UserInterfaceDetails user_interface_details = 3;
90+
repeated UserInterfaceDetails user_interface_details = 3;
9091
}
9192

9293
// measurement configuration info that is part of metadata
@@ -130,6 +131,8 @@ message Output {
130131
// message that holds measurement configurations at run time
131132
message MeasureRequest{
132133
google.protobuf.Any configuration_parameters = 1;
134+
135+
ni.measurements.PinMapContext pin_map_context = 2;
133136
}
134137

135138
// message that holds measurement outputs at run time
Lines changed: 25 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,25 @@
1+
syntax = "proto3";
2+
3+
package ni.measurements;
4+
5+
option csharp_namespace = "NationalInstruments.MeasurementServices";
6+
7+
option go_package = "nationalinstruments.com/measurementservices/pin_map_context;pin_map_context";
8+
9+
option java_multiple_files = true;
10+
11+
option java_outer_classname = "PinMapContextProto";
12+
13+
option java_package = "com.nationalinstruments.measurementservices";
14+
15+
option objc_class_prefix = "NIMS";
16+
17+
option php_namespace = "NationalInstruments\\MeasurementServices";
18+
19+
message PinMapContext {
20+
// Required. The resource id of the pin map in the Pin Map service that should be used for the call.
21+
string pin_map_id = 1;
22+
23+
// Optional. List of site numbers being used for the call. If unspecified, use all sites in the pin map.
24+
repeated int32 sites = 2;
25+
}

0 commit comments

Comments
 (0)