Fix some code smells

Author: nightowlengineer

src/main/java/engineer/nightowl/sonos/api/resource/AuthorizeResource.java

@@ -27,6 +27,8 @@
 public class AuthorizeResource extends BaseResource
 {
 
+    private final String HTTPS = "https";
+
     /**
      * <p>Constructor for AuthorizeResource.</p>
      *
@@ -51,7 +53,7 @@ public URI getAuthorizeCodeUri(final String redirectUri, final String state) thr
     {
         final SonosApiConfiguration configuration = apiClient.getConfiguration();
         final URIBuilder uri = new URIBuilder();
-        uri.setScheme("https");
+        uri.setScheme(HTTPS);
         uri.setHost(configuration.getAuthBaseUrl());
         uri.setPath("/login/v3/oauth");
         uri.setParameter("client_id", configuration.getApiKey());
@@ -96,7 +98,7 @@ public SonosToken createToken(final String redirectUri, final String authorizeCo
     {
         final SonosApiConfiguration configuration = apiClient.getConfiguration();
         final URIBuilder uri = new URIBuilder();
-        uri.setScheme("https");
+        uri.setScheme(HTTPS);
         uri.setHost(configuration.getAuthBaseUrl());
         uri.setPath("/login/v3/oauth/access");
 
@@ -145,7 +147,7 @@ public SonosToken refreshToken(final String refreshToken) throws SonosApiClientE
 
         // Setup URI
         final URIBuilder uri = new URIBuilder();
-        uri.setScheme("https");
+        uri.setScheme(HTTPS);
         uri.setHost(configuration.getAuthBaseUrl());
         uri.setPath("/login/v3/oauth/access");
 

src/main/java/engineer/nightowl/sonos/api/resource/PlayerVolumeResource.java

@@ -17,6 +17,7 @@
  */
 public class PlayerVolumeResource extends SubscribableResource
 {
+    private final String MUTED = "muted";
     /**
      * <p>Constructor for PlayerVolumeResource.</p>
      *
@@ -64,7 +65,7 @@ public SonosSuccess setMute(final String clientToken, final String playerId, fin
     {
         validateNotNull(isMuted);
         final Map<String, Object> payload = new HashMap<>();
-        payload.put("muted", isMuted);
+        payload.put(MUTED, isMuted);
         return postToApi(SonosSuccess.class, clientToken, String.format("/v1/players/%s/playerVolume/mute", playerId), payload);
     }
 
@@ -87,7 +88,7 @@ public SonosSuccess setRelativeVolume(final String clientToken, final String pla
         payload.put("volumeDelta", volumeDelta);
         if (!SonosUtilityHelper.isEmpty(isMuted))
         {
-            payload.put("muted", isMuted);
+            payload.put(MUTED, isMuted);
         }
         return postToApi(SonosSuccess.class, clientToken, String.format("/v1/players/%s/playerVolume/relative", playerId), payload);
     }
@@ -111,7 +112,7 @@ public SonosSuccess setVolume(final String clientToken, final String playerId, f
         payload.put("volume", volume);
         if (!SonosUtilityHelper.isEmpty(isMuted))
         {
-            payload.put("muted", isMuted);
+            payload.put(MUTED, isMuted);
         }
         return postToApi(SonosSuccess.class, clientToken, String.format("/v1/players/%s/playerVolume", playerId), payload);
     }

…ngineer/nightowl/sonos/api/BaseTest.java …er/nightowl/sonos/api/BaseTestSetup.javasrc/test/java/engineer/nightowl/sonos/api/BaseTest.java renamed to src/test/java/engineer/nightowl/sonos/api/BaseTestSetup.java src/test/java/engineer/nightowl/sonos/api/BaseTest.java renamed to src/test/java/engineer/nightowl/sonos/api/BaseTestSetup.java

@@ -2,7 +2,7 @@
 
 import org.junit.BeforeClass;
 
-public class BaseTest
+public class BaseTestSetup
 {
     protected static final SonosApiConfiguration configuration = new SonosApiConfiguration();