Fixed #26

Author: scott-xu

CHANGELOG.md

@@ -4,14 +4,17 @@ All notable changes to this project will be documented in this file.
 The format is based on [Keep a Changelog](http://keepachangelog.com/en/1.0.0/)
 and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.html).
 
-## [Unreleased]
+## [3.0.0-beta1]
 
 ### Added
  - Support .NET Standard 2.0
 
 ### Changed
 - Spelling: renamed "NonePublic" to "NonPublic"
 
+### Fixed
+- `GetNameWithoutGenericPart` Throws `SubString` exception [#26](https://github.com/ninject/Ninject.Extensions.Conventions/issues/26)
+
 ### Removed
  - .NET 3.5, .NET 4.0 and Silverlight
 

src/Ninject.Extensions.Conventions.Test/BindingGenerators/DefaultInterfaceBindingGeneratorTests.cs

@@ -71,7 +71,7 @@ public void InterfacesWithTheSameNameAreBound()
         [Fact]
         public void GenericInterfacesWithTheSameNameAreBound()
         {
-            var type = typeof(Bar<int>);
+            var type = typeof(ParentBar<int>.Bar<int>);
             var interfaces = new[] { typeof(IFoo), typeof(IBar), typeof(IBar<int>), typeof(IBar<>) };
             var expectedInterfaes = interfaces.Where(i => i.Name.StartsWith("IBar"));
             this.bindableInterfaceSelectorMock.Setup(s => s.GetBindableInterfaces(type)).Returns(interfaces);

src/Ninject.Extensions.Conventions.Test/BindingGenerators/DefaultInterfacesBindingGeneratorTests.cs

@@ -78,7 +78,7 @@ public void InterfacesContainedInClassesNameAreBound()
         [Fact]
         public void GenericInterfacesWithTheSameNameAreBound()
         {
-            var type = typeof(Bar<int>);
+            var type = typeof(ParentBar<int>.Bar<int>);
             var interfaces = new[] { typeof(IFoo), typeof(IBar), typeof(IBar<int>), typeof(IBar<>) };
             var expectedInterfaces = interfaces.Where(i => i.Name.StartsWith("IBar"));
             this.bindableInterfaceSelectorMock.Setup(s => s.GetBindableInterfaces(type)).Returns(interfaces);

src/Ninject.Extensions.Conventions.Test/Fakes/Bar.cs

@@ -21,7 +21,10 @@
 
 namespace Ninject.Extensions.Conventions.Fakes
 {
-    public class Bar<T> : IBar<T>, IBar, IBar<int, int>
+    public class ParentBar<T>
     {
+        public class Bar<T> : IBar<T>, IBar, IBar<int, int>
+        {
+        }
     }
 }

src/Ninject.Extensions.Conventions/BindingGenerators/AbstractInterfaceBindingGenerator.cs

@@ -85,7 +85,14 @@ protected static string GetNameWithoutGenericPart(Type type)
             }
 
             var genericMarkerPosition = name.IndexOf("`", StringComparison.Ordinal);
-            return name.Substring(0, genericMarkerPosition);
+            if (genericMarkerPosition > -1)
+            {
+                return name.Substring(0, genericMarkerPosition);
+            }
+            else
+            {
+                return name;
+            }
         }
     }
 }