Review fixes: Orleans best practices, performance, and correctness

MessengerGrain:
- Add ILogger, replace 10 bare catch blocks with logged exceptions
- Replace .Ignore() with LogAndForget helper (logs on failure)
- Parallel online status checks on activation, search, and accept
- Timer-based delivered flag batching (RegisterGrainTimer + flush on deactivate)
- Batch RemoveFriendsAsync into single DB query and single composer call
- Hoist mySummary before AcceptFriendRequestsAsync loop
- Tracked delete for atomic request removal + friendship creation
- Bound session message history per conversation
- Remove hardcoded limits: searchLimit, pageSize, maxIgnoreCapacity
  now passed from handlers via IConfiguration

Handlers:
- Add missing PlayerId guard clause to GetHeightMapMessageHandler
- Add IConfiguration to HabboSearchMessageHandler, GetMessengerHistoryMessageHandler,
  IgnoreUserMessageHandler for configurable limits
- Delete duplicate no-op GetCreditsInfoMessageHandler

Primitives:
- Remove unused MESSENGER_STATE constant from OrleansStateNames
- Add searchLimit, pageSize, maxIgnoreCapacity params to IMessengerGrain

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

Author: Diddyy

Turbo.PacketHandlers/FriendList/GetMessengerHistoryMessageHandler.cs

@@ -1,5 +1,6 @@
 using System.Threading;
 using System.Threading.Tasks;
+using Microsoft.Extensions.Configuration;
 using Orleans;
 using Turbo.Messages.Registry;
 using Turbo.Primitives.Messages.Incoming.FriendList;
@@ -8,10 +9,13 @@
 
 namespace Turbo.PacketHandlers.FriendList;
 
-public class GetMessengerHistoryMessageHandler(IGrainFactory grainFactory)
-    : IMessageHandler<GetMessengerHistoryMessage>
+public class GetMessengerHistoryMessageHandler(
+    IGrainFactory grainFactory,
+    IConfiguration configuration
+) : IMessageHandler<GetMessengerHistoryMessage>
 {
     private readonly IGrainFactory _grainFactory = grainFactory;
+    private readonly IConfiguration _configuration = configuration;
 
     public async ValueTask HandleAsync(
         GetMessengerHistoryMessage message,
@@ -22,9 +26,11 @@ CancellationToken ct
         if (ctx.PlayerId <= 0)
             return;
 
+        var pageSize = _configuration.GetValue<int>("Turbo:Messenger:MessageHistoryPageSize");
+
         var messengerGrain = _grainFactory.GetMessengerGrain(ctx.PlayerId);
         var history = await messengerGrain
-            .GetMessageHistoryAsync(message.ChatId, message.Message, ct)
+            .GetMessageHistoryAsync(message.ChatId, message.Message, pageSize, ct)
             .ConfigureAwait(false);
 
         await ctx.SendComposerAsync(

Turbo.PacketHandlers/FriendList/HabboSearchMessageHandler.cs

@@ -1,5 +1,6 @@
 using System.Threading;
 using System.Threading.Tasks;
+using Microsoft.Extensions.Configuration;
 using Orleans;
 using Turbo.Messages.Registry;
 using Turbo.Primitives.Messages.Incoming.FriendList;
@@ -8,10 +9,11 @@
 
 namespace Turbo.PacketHandlers.FriendList;
 
-public class HabboSearchMessageHandler(IGrainFactory grainFactory)
+public class HabboSearchMessageHandler(IGrainFactory grainFactory, IConfiguration configuration)
     : IMessageHandler<HabboSearchMessage>
 {
     private readonly IGrainFactory _grainFactory = grainFactory;
+    private readonly IConfiguration _configuration = configuration;
 
     public async ValueTask HandleAsync(
         HabboSearchMessage message,
@@ -22,9 +24,11 @@ CancellationToken ct
         if (ctx.PlayerId <= 0)
             return;
 
+        var searchLimit = _configuration.GetValue<int>("Turbo:Messenger:SearchResultLimit");
+
         var messengerGrain = _grainFactory.GetMessengerGrain(ctx.PlayerId);
         var (friends, others) = await messengerGrain
-            .SearchPlayersAsync(message.SearchQuery, ct)
+            .SearchPlayersAsync(message.SearchQuery, searchLimit, ct)
             .ConfigureAwait(false);
 
         await ctx.SendComposerAsync(

Turbo.PacketHandlers/Users/IgnoreUserMessageHandler.cs

@@ -1,5 +1,6 @@
 using System.Threading;
 using System.Threading.Tasks;
+using Microsoft.Extensions.Configuration;
 using Orleans;
 using Turbo.Messages.Registry;
 using Turbo.Primitives.Messages.Incoming.Users;
@@ -9,10 +10,11 @@
 
 namespace Turbo.PacketHandlers.Users;
 
-public class IgnoreUserMessageHandler(IGrainFactory grainFactory)
+public class IgnoreUserMessageHandler(IGrainFactory grainFactory, IConfiguration configuration)
     : IMessageHandler<IgnoreUserMessage>
 {
     private readonly IGrainFactory _grainFactory = grainFactory;
+    private readonly IConfiguration _configuration = configuration;
 
     public async ValueTask HandleAsync(
         IgnoreUserMessage message,
@@ -25,8 +27,12 @@ CancellationToken ct
 
         var targetId = PlayerId.Parse(message.PlayerId);
 
+        var maxIgnoreCapacity = _configuration.GetValue<int>("Turbo:Messenger:IgnoreListLimit");
+
         var messengerGrain = _grainFactory.GetMessengerGrain(ctx.PlayerId);
-        var result = await messengerGrain.IgnoreUserAsync(targetId, ct).ConfigureAwait(false);
+        var result = await messengerGrain
+            .IgnoreUserAsync(targetId, maxIgnoreCapacity, ct)
+            .ConfigureAwait(false);
 
         await ctx.SendComposerAsync(
                 new IgnoreResultMessageComposer { Result = result, PlayerName = string.Empty },