From 542f3d762edb6a66434b9fb0b32f5f442c25838f Mon Sep 17 00:00:00 2001 From: Ty-Sir Date: Tue, 24 Mar 2026 13:05:26 -0400 Subject: [PATCH 1/3] chore: add missing vaultLeaderComission type in UserNonFundingLedgerUpdatesResponse --- .../info/_methods/userNonFundingLedgerUpdates.ts | 14 ++++++++++++++ tests/api/info/userNonFundingLedgerUpdates.test.ts | 1 + 2 files changed, 15 insertions(+) diff --git a/src/api/info/_methods/userNonFundingLedgerUpdates.ts b/src/api/info/_methods/userNonFundingLedgerUpdates.ts index a08868cd..ea9e9d02 100644 --- a/src/api/info/_methods/userNonFundingLedgerUpdates.ts +++ b/src/api/info/_methods/userNonFundingLedgerUpdates.ts @@ -389,6 +389,20 @@ export type UserNonFundingLedgerUpdatesResponse = { * @pattern ^[0-9]+(\.[0-9]+)?$ */ amount: string; + } + | { + /** Update type. */ + type: "vaultLeaderCommission"; + /** + * Address of the leader. + * @pattern ^0x[a-fA-F0-9]{40}$ + */ + user: `0x${string}`; + /** + * Amount earned in USDC. + * @pattern ^[0-9]+(\.[0-9]+)?$ + */ + usdc: string; }; }[]; diff --git a/tests/api/info/userNonFundingLedgerUpdates.test.ts b/tests/api/info/userNonFundingLedgerUpdates.test.ts index c4cdb44b..383f6ffe 100644 --- a/tests/api/info/userNonFundingLedgerUpdates.test.ts +++ b/tests/api/info/userNonFundingLedgerUpdates.test.ts @@ -25,6 +25,7 @@ runTest({ { user: "0x563C175E6f11582f65D6d9E360A618699DEe14a9", startTime: now - fiveYears }, // startTime present { user: "0x563C175E6f11582f65D6d9E360A618699DEe14a9", startTime: now - fiveYears, endTime: now }, // endTime present { user: "0x563C175E6f11582f65D6d9E360A618699DEe14a9", startTime: now - fiveYears, endTime: null }, // endTime null + { user: "0x288ed4efc8fbd1e42a06fe083ea942d20c90b336", startTime: now - fiveYears }, // vaultLeaderComission + startTime present ]; const data = await Promise.all(params.map((p) => client.userNonFundingLedgerUpdates(p))); From b468ed7138797bf81ef70b699b55d205f2944c5a Mon Sep 17 00:00:00 2001 From: Ty-Sir Date: Tue, 24 Mar 2026 13:09:37 -0400 Subject: [PATCH 2/3] chore: add test user to subscription userNonFundingLedgerUpdates test for vaultLeaderCommission type --- tests/api/subscription/userNonFundingLedgerUpdates.test.ts | 1 + 1 file changed, 1 insertion(+) diff --git a/tests/api/subscription/userNonFundingLedgerUpdates.test.ts b/tests/api/subscription/userNonFundingLedgerUpdates.test.ts index 8e157692..182332b5 100644 --- a/tests/api/subscription/userNonFundingLedgerUpdates.test.ts +++ b/tests/api/subscription/userNonFundingLedgerUpdates.test.ts @@ -23,6 +23,7 @@ runTest({ { user: "0xc65008a70F511ae0407D26022ff1516422AceA94" }, { user: "0x4993a3a6b03414ae9cf02a545db7a04af7c9f291" }, { user: "0x11fe8a3dbc48b7b8138cdc9538015e2b928b86e8" }, + { user: "0x288ed4efc8fbd1e42a06fe083ea942d20c90b336" }, ]; const data = await collectEventsOverTime(async (cb) => { From e8f676e3d91310e69105d3bd01f76cbfdd098f15 Mon Sep 17 00:00:00 2001 From: nktkas Date: Thu, 26 Mar 2026 14:42:45 +0200 Subject: [PATCH 3/3] chore: correct user address for vaultLeaderCommission in userNonFundingLedgerUpdates test --- tests/api/info/userNonFundingLedgerUpdates.test.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/api/info/userNonFundingLedgerUpdates.test.ts b/tests/api/info/userNonFundingLedgerUpdates.test.ts index 383f6ffe..73021b18 100644 --- a/tests/api/info/userNonFundingLedgerUpdates.test.ts +++ b/tests/api/info/userNonFundingLedgerUpdates.test.ts @@ -25,7 +25,7 @@ runTest({ { user: "0x563C175E6f11582f65D6d9E360A618699DEe14a9", startTime: now - fiveYears }, // startTime present { user: "0x563C175E6f11582f65D6d9E360A618699DEe14a9", startTime: now - fiveYears, endTime: now }, // endTime present { user: "0x563C175E6f11582f65D6d9E360A618699DEe14a9", startTime: now - fiveYears, endTime: null }, // endTime null - { user: "0x288ed4efc8fbd1e42a06fe083ea942d20c90b336", startTime: now - fiveYears }, // vaultLeaderComission + startTime present + { user: "0x33199a11ddb431fd8175ad5f20d989662527a3e6", startTime: now - fiveYears }, // vaultLeaderCommission ]; const data = await Promise.all(params.map((p) => client.userNonFundingLedgerUpdates(p)));