Skip to content

Commit 3693861

Browse files
beliefgpdead-horse
authored andcommitted
fix: check number exclude NaN (#30)
1 parent 67d8cf6 commit 3693861

2 files changed

Lines changed: 7 additions & 1 deletion

File tree

index.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -221,7 +221,7 @@ function checkInt(rule, value) {
221221
*/
222222

223223
function checkNumber(rule, value) {
224-
if (typeof value !== 'number') {
224+
if (typeof value !== 'number' || isNaN(value)) {
225225
return this.t('should be a number');
226226
}
227227
if (rule.hasOwnProperty('max') && value > rule.max) {

test/index.test.js

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -115,6 +115,12 @@ describe('parameter', function () {
115115
parameter.validate(rule, value)[0].message.should.equal('should be a number');
116116
});
117117

118+
it('should check NaN error', function () {
119+
var value = { number: NaN };
120+
var rule = { number: 'number' };
121+
parameter.validate(rule, value)[0].message.should.equal('should be a number');
122+
});
123+
118124
it('should check max error', function () {
119125
var value = { number: 101 };
120126
var rule = { number: {type: 'number', max: 100, min: 1 }};

0 commit comments

Comments
 (0)