Support -codesign option for macdeployqt (#40)

Author: tadaskay

README.md

@@ -29,6 +29,12 @@ Currently if you need to produce a build you need to run the packer in different
   `npx nodegui-packer --pack <path to dist>`
 
   This command essential takes the dist folder as the input and puts it in the suitable location inside the standalone executable. Also it runs the correct deployment tool (macdeployqt incase of mac, etc) and packs in the dependencies. The output of the command is found under the build directory. You should gitignore the build directory.
+  
+- macOS supports signing the application:
+
+  `npx nodegui-packer --pack <path to dist> --sign <identity>`
+  
+  Identity should be added to the keychain and trusted first. Its value can be copied from: `security find-identity -p codesigning`
 
 # How does it work ?
 

src/cli.ts

@@ -6,7 +6,8 @@ import { getPacker } from "./index";
 
 program
   .option("-i, --init <name>", "Creates initial deploy files")
-  .option("-p, --pack <distPath>", "Packs the app into deployable");
+  .option("-p, --pack <distPath>", "Packs the app into deployable")
+  .option("-s, --sign <identity>", "Signs the app during packing using identity (macOS)");
 
 program.parse(process.argv);
 const options = program.opts();
@@ -19,5 +20,5 @@ if (program.init) {
 }
 
 if (program.pack) {
-  packer.pack(options.pack);
+  packer.pack(options.pack, options.sign);
 }

src/darwin/index.ts

@@ -19,7 +19,13 @@ const copyAppDist = async (distPath: string, resourceDir: string) => {
   });
 };
 
-const runMacDeployQt = async (appName: string, buildDir: string) => {
+export type macDeployQtOptions = {
+  appName: string,
+  buildDir: string,
+  identity?: string,
+}
+
+const runMacDeployQt = async ({appName, buildDir, identity}: macDeployQtOptions) => {
   const qtHome = process.env.QT_INSTALL_DIR || qode.qtHome;
   const macDeployQtBin = path.resolve(qtHome, "bin", "macdeployqt");
   try {
@@ -30,7 +36,12 @@ const runMacDeployQt = async (appName: string, buildDir: string) => {
 
   const macDeployQt = spawn(
     macDeployQtBin,
-    [`${appName}.app`, "-dmg", "-verbose=3", `-libpath ${qode.qtHome}`],
+    [`${appName}.app`,
+      "-dmg",
+      "-verbose=3",
+      `-libpath ${qode.qtHome}`,
+        ...(identity ? [`-codesign=${identity}`] : [])
+    ],
     { cwd: buildDir }
   );
 
@@ -65,7 +76,7 @@ export const init = async (appName: string) => {
   await fs.writeJSON(configFile, config);
 };
 
-export const pack = async (distPath: string) => {
+export const pack = async (distPath: string, identity?: string) => {
   const config = await fs.readJSON(
     path.resolve(deployDirectory, "config.json")
   );
@@ -86,6 +97,6 @@ export const pack = async (distPath: string) => {
   console.log(`copying dist`);
   await copyAppDist(distPath, Resources);
   console.log(`running macdeployqt`);
-  await runMacDeployQt(appName, buildDir);
+  await runMacDeployQt({ appName, buildDir, identity });
   console.log(`Build successful. Find the dmg/app at ${buildDir}`);
 };