Merge pull request #32 from nodegui/feature/add-scrollarea

Feature/add scrollarea

Author: a7ul

package-lock.json

@@ -1,6 +1,6 @@
 {
   "name": "@nodegui/react-nodegui",
-  "version": "0.1.5",
+  "version": "0.1.9",
   "description": "React Native for building cross platform desktop applications",
   "main": "dist/index.js",
   "files": [
@@ -22,7 +22,7 @@
     "react": "16.9.0"
   },
   "devDependencies": {
-    "@nodegui/nodegui": "^0.1.7",
+    "@nodegui/nodegui": "^0.1.9",
     "@types/node": "^12.0.10",
     "@types/react-reconciler": "^0.18.0",
     "prettier": "^1.18.2",

package.json

@@ -0,0 +1,45 @@
+import { QIcon, QPushButton, NodeWidget } from "@nodegui/nodegui";
+import { ViewProps, setProps as setViewProps } from "../View/RNView";
+import { RNWidget } from "../config";
+import { throwUnsupported } from "../../utils/helpers";
+
+export class RNButton extends QPushButton implements RNWidget {
+  appendInitialChild(child: NodeWidget): void {
+    throwUnsupported(this);
+  }
+  appendChild(child: NodeWidget): void {
+    throwUnsupported(this);
+  }
+  insertBefore(child: NodeWidget, beforeChild: NodeWidget): void {
+    throwUnsupported(this);
+  }
+  removeChild(child: NodeWidget): void {
+    throwUnsupported(this);
+  }
+  static tagName = "button";
+}
+export interface ButtonProps extends ViewProps {
+  text?: string;
+  flat?: boolean;
+  icon?: QIcon;
+}
+
+export const setProps = (
+  widget: RNButton,
+  newProps: ButtonProps,
+  oldProps: ButtonProps
+) => {
+  const setter: ButtonProps = {
+    set text(buttonText: string) {
+      widget.setText(buttonText);
+    },
+    set flat(isFlat: boolean) {
+      widget.setFlat(isFlat);
+    },
+    set icon(icon: QIcon) {
+      widget.setIcon(icon);
+    }
+  };
+  Object.assign(setter, newProps);
+  setViewProps(widget, newProps, oldProps);
+};

src/components/Button/RNButton.ts

@@ -1,35 +1,10 @@
-import { QPushButton, QIcon, NodeWidget } from "@nodegui/nodegui";
+import { NodeWidget } from "@nodegui/nodegui";
 import { Fiber } from "react-reconciler";
-import { ViewProps, setProps as setViewProps } from "../View";
 import { registerComponent, ComponentConfig } from "../config";
-interface ButtonProps extends ViewProps {
-  text?: string;
-  flat?: boolean;
-  icon?: QIcon;
-}
-
-const setProps = (
-  widget: QPushButton,
-  newProps: ButtonProps,
-  oldProps: ButtonProps
-) => {
-  const setter: ButtonProps = {
-    set text(buttonText: string) {
-      widget.setText(buttonText);
-    },
-    set flat(isFlat: boolean) {
-      widget.setFlat(isFlat);
-    },
-    set icon(icon: QIcon) {
-      widget.setIcon(icon);
-    }
-  };
-  Object.assign(setter, newProps);
-  setViewProps(widget, newProps, oldProps);
-};
+import { setProps, ButtonProps, RNButton } from "./RNButton";
 
 class ButtonConfig extends ComponentConfig {
-  id = "button";
+  tagName = RNButton.tagName;
   shouldSetTextContent(nextProps: object): boolean {
     return true;
   }
@@ -39,7 +14,7 @@ class ButtonConfig extends ComponentConfig {
     context: any,
     workInProgress: Fiber
   ): NodeWidget {
-    const widget = new QPushButton();
+    const widget = new RNButton();
     setProps(widget, newProps, {});
     return widget;
   }
@@ -50,7 +25,7 @@ class ButtonConfig extends ComponentConfig {
     newProps: object,
     finishedWork: Fiber
   ): void {
-    setProps(instance as QPushButton, newProps, oldProps);
+    setProps(instance as RNButton, newProps, oldProps);
   }
 }
 

src/components/Button/index.ts

@@ -0,0 +1,42 @@
+import { ViewProps, setProps as setViewProps } from "../View/RNView";
+import { QCheckBox, NodeWidget } from "@nodegui/nodegui";
+import { RNWidget } from "../config";
+import { throwUnsupported } from "../../utils/helpers";
+
+export class RNCheckBox extends QCheckBox implements RNWidget {
+  appendInitialChild(child: NodeWidget): void {
+    throwUnsupported(this);
+  }
+  appendChild(child: NodeWidget): void {
+    throwUnsupported(this);
+  }
+  insertBefore(child: NodeWidget, beforeChild: NodeWidget): void {
+    throwUnsupported(this);
+  }
+  removeChild(child: NodeWidget): void {
+    throwUnsupported(this);
+  }
+  static tagName = "checkbox";
+}
+
+export interface CheckBoxProps extends ViewProps {
+  text?: string;
+  checked?: boolean;
+}
+
+export const setProps = (
+  widget: RNCheckBox,
+  newProps: CheckBoxProps,
+  oldProps: CheckBoxProps
+) => {
+  const setter: CheckBoxProps = {
+    set text(checkboxText: string) {
+      widget.setText(checkboxText);
+    },
+    set checked(isChecked: boolean) {
+      widget.setChecked(isChecked);
+    }
+  };
+  Object.assign(setter, newProps);
+  setViewProps(widget, newProps, oldProps);
+};