Skip to content

Key order in keys/node.keys does not match node/README.md sort order by first name #2569

Description

@MikeMcC399

Situation

Running the tool ./update-keys.sh writes the keys in keys/node.keys in the same order that they are listed in the source on nodejs/node > Release keys where they are sorted in order of first name.

This causes a difference:

$ git diff
diff --git a/keys/node.keys b/keys/node.keys
index 3ae5e6b6..a3c92ce2 100644
--- a/keys/node.keys
+++ b/keys/node.keys
@@ -5,5 +5,5 @@ CC68F5A3106FF448322E48ED27F5E38D5B0A215F
 890C08DB8579162FEE0DF9DB8BEAB4DFCF555EF4
 C82FA3AE1CBEDC6BE46B9360C43CEC45C17AB93C
 108F52B48DB57BB0CC439B2997B01419BD92F80A
-A363A499291CBBC940DD62E41F10027AF002F8B0
 655F3B5C1FB3FA8D1A0CA6BDE4A7D232B936D2FD
+A363A499291CBBC940DD62E41F10027AF002F8B0

PR #2551 placed the new key 655F3B5C1FB3FA8D1A0CA6BDE4A7D232B936D2FD for @sxa at the end of the file, and not in the second to last place to conform with the node README.

Running ./update-keys.sh ideally should make no changes if the keys/node.keys is supposed to be up to date.

Suggestion

  1. Wait to see if PR chore: switch to official release-keys repo to verify Node.js artefacts #2415 achieves consensus and is landed. In this case keys/node.keys is deleted and the issue is resolved automatically, and for any future changes.
  2. If an automated update is not approved and landed, then re-sync the key order.

This is a housekeeping exercise only. The order of the keys in keys/node.keys does not affect their usage when building Docker images.

Metadata

Metadata

Assignees

No one assigned

    Type

    Fields

    No fields configured for Task.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions