You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
PR #2551 placed the new key 655F3B5C1FB3FA8D1A0CA6BDE4A7D232B936D2FD for @sxa at the end of the file, and not in the second to last place to conform with the node README.
Situation
Running the tool ./update-keys.sh writes the keys in keys/node.keys in the same order that they are listed in the source on nodejs/node > Release keys where they are sorted in order of first name.
This causes a difference:
PR #2551 placed the new key
655F3B5C1FB3FA8D1A0CA6BDE4A7D232B936D2FDfor @sxa at the end of the file, and not in the second to last place to conform with the node README.Running ./update-keys.sh ideally should make no changes if the keys/node.keys is supposed to be up to date.
Suggestion
release-keysrepo to verify Node.js artefacts #2415 achieves consensus and is landed. In this case keys/node.keys is deleted and the issue is resolved automatically, and for any future changes.This is a housekeeping exercise only. The order of the keys in keys/node.keys does not affect their usage when building Docker images.