Skip to content

Commit 0f6e412

Browse files
kraenhansenclaude
andcommitted
Remove simplified test_instance_data port
The upstream test verifies finalizer and environment teardown behavior via subprocesses and worker threads, not just increment(). The simplified CTS port lost that coverage, so remove it and reclassify as Medium. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
1 parent deeea09 commit 0f6e412

4 files changed

Lines changed: 1 addition & 103 deletions

File tree

PORTING.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -60,7 +60,7 @@ Tests covering the engine-specific part of Node-API, defined in `js_native_api.h
6060
| `test_function` | Not ported | Medium |
6161
| `test_general` | Not ported | Hard |
6262
| `test_handle_scope` | Ported ✅ | Easy |
63-
| `test_instance_data` | Ported ✅ | Easy |
63+
| `test_instance_data` | Not ported | Medium |
6464
| `test_new_target` | Ported ✅ | Easy |
6565
| `test_number` | Ported ✅ | Easy |
6666
| `test_object` | Not ported | Hard |

tests/js-native-api/test_instance_data/CMakeLists.txt

Lines changed: 0 additions & 1 deletion
This file was deleted.

tests/js-native-api/test_instance_data/test.js

Lines changed: 0 additions & 5 deletions
This file was deleted.

tests/js-native-api/test_instance_data/test_instance_data.c

Lines changed: 0 additions & 96 deletions
This file was deleted.

0 commit comments

Comments
 (0)