File tree Expand file tree Collapse file tree
Expand file tree Collapse file tree Original file line number Diff line number Diff line change @@ -48,13 +48,11 @@ export default class MetadataGenerator {
4848 meta . unshift ( `Backport-PR-URL: ${ prUrl } ` ) ;
4949 meta . unshift ( `PR-URL: ${ altPrUrl } ` ) ;
5050 } else {
51- // Reviews are only added here as backports should not contain reviews
52- // for the backport itself in the metadata
5351 meta . unshift ( `PR-URL: ${ prUrl } ` ) ;
54- meta . push (
55- ...reviewedBy . map ( ( r ) => `Reviewed-By: ${ r . reviewer . getContact ( ) } ` )
56- ) ;
5752 }
53+ meta . push (
54+ ...reviewedBy . map ( ( r ) => `Reviewed-By: ${ r . reviewer . getContact ( ) } ` )
55+ ) ;
5856 meta . push ( '' ) ; // creates final EOL
5957 return meta . join ( '\n' ) ;
6058 }
Original file line number Diff line number Diff line change @@ -45,6 +45,10 @@ const backportExpected = `PR-URL: https://github.com/nodejs/node/pull/29995
4545Backport-PR-URL: https://github.com/nodejs/node/pull/30072
4646Fixes: https://github.com/nodejs/build/issues/1961
4747Refs: https://github.com/nodejs/node/commit/53ca0b9ae145c430842bf78e553e3b6cbd2823aa#commitcomment-35494896
48+ Reviewed-By: Foo User <foo@example.com>
49+ Reviewed-By: Quux User <quux@example.com>
50+ Reviewed-By: Baz User <baz@example.com>
51+ Reviewed-By: Bar User <bar@example.com>
4852` ;
4953
5054const selfRefData = Object . assign ( { } , data , { pr : selfRefPR } ) ;
You can’t perform that action at this time.
0 commit comments