Skip to content

Commit 3218828

Browse files
committed
http: fix style and naming
1 parent 45fa652 commit 3218828

1 file changed

Lines changed: 8 additions & 7 deletions

File tree

src/node_http_parser_impl.h

Lines changed: 8 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -180,7 +180,7 @@ class Parser : public AsyncWrap, public StreamListener {
180180

181181

182182
int on_url(const char* at, size_t length) {
183-
int rv = TrackHeader(length, before_headers);
183+
int rv = TrackHeader(length, kBeforeHeaders);
184184
if (rv != 0) {
185185
return rv;
186186
}
@@ -825,19 +825,20 @@ class Parser : public AsyncWrap, public StreamListener {
825825
got_exception_ = false;
826826
}
827827

828-
enum tracking_position {
829-
before_headers,
830-
after_request_line
828+
enum HeaderTrackState {
829+
kBeforeHeaders,
830+
kAfterRequestLine
831831
};
832-
int TrackHeader(size_t len, enum tracking_position pos = after_request_line) {
832+
833+
int TrackHeader(size_t len, enum HeaderTrackState pos = kAfterRequestLine) {
833834
#ifdef NODE_EXPERIMENTAL_HTTP
834835
header_nread_ += len;
835-
if (pos == before_headers &&
836+
if (pos == kBeforeHeaders &&
836837
header_nread_ >= per_process::cli_options->max_http_uri_size) {
837838
llhttp_set_error_reason(&parser_,
838839
"HPE_URI_OVERFLOW:URI overflow");
839840
return HPE_USER;
840-
} else if (pos == after_request_line &&
841+
} else if (pos == kAfterRequestLine &&
841842
header_nread_ >= per_process::cli_options->max_http_header_size) {
842843
llhttp_set_error_reason(&parser_, "HPE_HEADER_OVERFLOW:Header overflow");
843844
return HPE_USER;

0 commit comments

Comments
 (0)