test-snapshot-typescript should work with typescript 6

[kapouer]

Version

24.15.0

Platform

Linux lal 7.0.7+deb14-amd64 #1 SMP PREEMPT_DYNAMIC Debian 7.0.7-1 (2026-05-15) x86_64 GNU/Linux

Subsystem

test

What steps will reproduce the bug?

Replace test/fixtures/snapshot/typescript.js by typescript 6 bundle.

How often does it reproduce? Is there a required condition?

As a distributor, we avoid bundled software when not strictly necessary.
test/fixtures/snapshot/typescript.js
is such a thing. Instead, I use a copy of the node-typescript debian package files, setup before the tests.

What is the expected behavior? Why is that the expected behavior?

No test error.

What do you see instead?

105s AssertionError [ERR_ASSERTION]: Expected values to be strictly equal:
105s + actual - expected
105s
105s + '"use strict";\n' +
105s + 'class VirtualPoint {\n' +
105s + ' x;\n' +
105s + ' y;\n' +
105s + ' constructor(x, y) {\n' +
105s - 'var VirtualPoint = /** @Class */ (function () {\n' +
105s - ' function VirtualPoint(x, y) {\n' +
105s ' this.x = x;\n' +
105s ' this.y = y;\n' +
105s ' }\n' +
105s + '}\n' +
105s + 'const newVPoint = new VirtualPoint(13, 56);\n'
105s - ' return VirtualPoint;\n' +
105s - '}());\n' +
105s - 'var newVPoint = new VirtualPoint(13, 56);\n'

Additional information

Something like this could help

--- a/test/fixtures/snapshot/typescript-main.js
+++ b/test/fixtures/snapshot/typescript-main.js
@@ -20,7 +20,10 @@
     source,
     {
       compilerOptions: {
-        module: ts.ModuleKind.CommonJS
+        module: ts.ModuleKind.CommonJS,
+        strict: false,
+        alwaysStrict: false,
+        target: 'es5'
       }
     });

[joyeecheung]

This is a test fixture and essentially it only serves as ”a huge blob of sophisticated enough real-world JavaScript for testing”. The fact that it’s an outdated copy of a popular library instead of randomly generated gibberish can be seen as mostly a coincidence. It is not used by the Node.js binary. Is there a reason why the downstream distribution is bundling a test fixture at all?

[kapouer]

Le mer. 20 mai 2026, 02:30, Joyee Cheung ***@***.***> a écrit :

*joyeecheung* left a comment (nodejs/node#63427) <#63427 (comment)> This is a test fixture and essentially it only serves as a”a huge blob of sophisticated enough real-world JavaScript for testing”. Is there a reason why the downstream distribution is bundling a test fixture at all?

Yes because we run most unit tests

…

— Reply to this email directly, view it on GitHub <#63427 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AABACTRMF2UA5TR2IIMTHE343T4DZAVCNFSM6AAAAACZEEEKUOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHM2DIOJTGM4DEOJTG4> . Triage notifications on the go with GitHub Mobile for iOS <https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675> or Android <https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>. You are receiving this because you authored the thread.Message ID: ***@***.***>