Skip to content

src,sqlite: only pass xFilter when user provided a callback#63516

Merged
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
aduh95:xFilter-changeset
May 25, 2026
Merged

src,sqlite: only pass xFilter when user provided a callback#63516
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
aduh95:xFilter-changeset

Conversation

@aduh95
Copy link
Copy Markdown
Contributor

@aduh95 aduh95 commented May 23, 2026

According to https://sqlite.org/session.html#sqlite3changeset_apply, passing NULL is allowed and does what we want; I assume it's more performant.

@aduh95
src,sqlite: only pass xFilter when user provided a callback
b6cce12 
Signed-off-by: Antoine du Hamel <duhamelantoine1995@gmail.com>
@nodejs-github-bot
Copy link
Copy Markdown
Collaborator

nodejs-github-bot commented May 23, 2026

Review requested:

  • @nodejs/sqlite

@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. sqlite Issues and PRs related to the SQLite subsystem. labels May 23, 2026
@codecov
Copy link
Copy Markdown

codecov Bot commented May 23, 2026 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.14%. Comparing base (8d3245e) to head (b6cce12).
⚠️ Report is 37 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main   #63516   +/-   ##
=======================================
  Coverage   90.14%   90.14%           
=======================================
  Files         718      718           
  Lines      227984   227983    -1     
  Branches    42835    42825   -10     
=======================================
+ Hits       205522   205525    +3     
- Misses      14235    14240    +5     
+ Partials     8227     8218    -9
Files with missing lines Coverage Δ
src/node_sqlite.cc 80.62% <100.00%> (-0.01%) ⬇️

... and 30 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@louwers
Copy link
Copy Markdown
Contributor

louwers commented May 23, 2026

LGTM

@aduh95 aduh95 added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. labels May 23, 2026
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label May 23, 2026
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@aduh95
Copy link
Copy Markdown
Contributor Author

aduh95 commented May 23, 2026

@geeksilva97 please do not start fresh CI when it's not needed

node/doc/contributing/collaborator-guide.md

Lines 273 to 280 in df6973e

If there are Jenkins CI failures unrelated to the change in the pull
request, try "Resume Build". It is in the left navigation of the relevant
`node-test-pull-request` job. (Do not be tempted to do this on the lower
level `node-test-commit` job as it will not report the updated result back
to the PR.) It will preserve all the green results from the current job but
re-run everything else. Start a fresh CI by pressing "Retry" if more than
seven days have elapsed since the original failing CI as the compiled
binaries for the Windows and ARM platforms are only kept for seven days.

@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot
Copy link
Copy Markdown
Collaborator

nodejs-github-bot commented May 25, 2026

CI: https://ci.nodejs.org/job/node-test-pull-request/73711/

@aduh95 aduh95 added the commit-queue Add this label to land a pull request using GitHub Actions. label May 25, 2026
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label May 25, 2026
@nodejs-github-bot nodejs-github-bot merged commit b9203ee into nodejs:main May 25, 2026
90 checks passed
@nodejs-github-bot
Copy link
Copy Markdown
Collaborator

nodejs-github-bot commented May 25, 2026

Landed in b9203ee

@aduh95 aduh95 deleted the xFilter-changeset branch May 25, 2026 20:41
aduh95 added a commit that referenced this pull request May 27, 2026
@aduh95
src,sqlite: only pass xFilter when user provided a callback
9bda929 
Signed-off-by: Antoine du Hamel <duhamelantoine1995@gmail.com>
PR-URL: #63516
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: René <contact.9a5d6388@renegade334.me.uk>
Reviewed-By: Edy Silva <edigleyssonsilva@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cjihrig cjihrig cjihrig approved these changes

@Renegade334 Renegade334 Renegade334 approved these changes

@geeksilva97 geeksilva97 geeksilva97 approved these changes

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no pending requests for changes, and a CI started. c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. sqlite Issues and PRs related to the SQLite subsystem.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@aduh95 @nodejs-github-bot @louwers @cjihrig @Renegade334 @geeksilva97