code enhancements

Author: mihaidma

CHANGELOG.md

@@ -1,4 +1,4 @@
-* Coveralls integration
+* Integrated Coveralls on search and info pages
 * Set Up Mocha and Instabul
 
 ## 11 April 2016 - 6.1.0

client/components/module-source.js

@@ -1,6 +1,7 @@
 'use strict'
 
 import React from 'react'
+import classNames from 'classnames'
 
 export const ModuleSource = React.createClass({
   propTypes: {
@@ -9,17 +10,12 @@ export const ModuleSource = React.createClass({
     imgSrc: React.PropTypes.string
   },
   render () {
-    let {imgSrc, sourceName} = this.props
-    let imgClassName = imgSrc && `img-badge`
-    let className = !imgSrc && `logo logo-${this.props.sourceName} ${this.props.className}`
-    let source = this.props.data[sourceName]
-    let url = source ? source.url : ''
-    let img = imgSrc && <img src={imgSrc} alt={sourceName} className={imgClassName}/>
+    let {imgSrc, sourceName, className, data: {[sourceName]: source}, data: {[sourceName]: {url: url}}} = this.props
+    let logoClass = classNames({[`logo logo-${sourceName} ${className}`]: !imgSrc})
+    let img = imgSrc && <img src={imgSrc} alt={sourceName} className="img-badge"/>
 
     return (
-      source && source.connected
-        ? <a href={url} target='_blank' target="_blank" className={className}>{img}</a>
-        : null
+      source && source.connected && <a href={url} target='_blank' target="_blank" className={logoClass}>{img}</a>
     )
   }
 })

client/components/search-result.js

@@ -31,9 +31,9 @@ export const SearchResult = React.createClass({
             <ModuleSource data={result} sourceName="npm"/>
             {this.hasBuild(result.travis) ? null :
               <ModuleSource data={result} sourceName="travis"/>}
-            {result.coveralls && result.coveralls.badgeUrl
-              ? <ModuleSource data={result} sourceName="coveralls" imgSrc={result.coveralls.badgeUrl}/>
-              : null}
+            {result.coveralls && result.coveralls.badgeUrl &&
+              <ModuleSource data={result} sourceName="coveralls" imgSrc={result.coveralls.badgeUrl}/>
+            }
           </div>
         </div>
         <p className="module-description">

package.json

@@ -60,7 +60,8 @@
     "style-loader": "0.13.x",
     "superagent": "1.6.x",
     "vidi-metrics": "0.1.0",
-    "vidi-seneca-metrics": "0.2.0"
+    "vidi-seneca-metrics": "0.2.0",
+    "classnames": "2.2.x"
   },
   "devDependencies": {
     "babel-core": "6.4.x",