Upgrade to Swift 5

Author: Bennett Yuan

MissionControl.xcodeproj/project.pbxproj

@@ -400,11 +400,11 @@
 					};
 					8B63137A1CE5F9A10029DC98 = {
 						CreatedOnToolsVersion = 7.3.1;
-						LastSwiftMigration = 0800;
+						LastSwiftMigration = 1020;
 					};
 					8B6313841CE5F9A10029DC98 = {
 						CreatedOnToolsVersion = 7.3.1;
-						LastSwiftMigration = 0800;
+						LastSwiftMigration = 1020;
 					};
 				};
 			};
@@ -413,6 +413,7 @@
 			developmentRegion = English;
 			hasScannedForEncodings = 0;
 			knownRegions = (
+				English,
 				en,
 			);
 			mainGroup = 8B6313711CE5F9A10029DC98;
@@ -875,7 +876,7 @@
 				PRODUCT_NAME = MissionControl;
 				SKIP_INSTALL = YES;
 				SWIFT_OPTIMIZATION_LEVEL = "-Onone";
-				SWIFT_VERSION = 3.0;
+				SWIFT_VERSION = 5.0;
 			};
 			name = Debug;
 		};
@@ -896,7 +897,7 @@
 				PRODUCT_NAME = MissionControl;
 				SKIP_INSTALL = YES;
 				SWIFT_OPTIMIZATION_LEVEL = "-Owholemodule";
-				SWIFT_VERSION = 3.0;
+				SWIFT_VERSION = 5.0;
 			};
 			name = Release;
 		};
@@ -907,7 +908,7 @@
 				LD_RUNPATH_SEARCH_PATHS = "$(inherited) @executable_path/Frameworks @loader_path/Frameworks";
 				PRODUCT_BUNDLE_IDENTIFIER = com.appculture.MissionControlTests;
 				PRODUCT_NAME = "$(TARGET_NAME)";
-				SWIFT_VERSION = 3.0;
+				SWIFT_VERSION = 5.0;
 			};
 			name = Debug;
 		};
@@ -919,7 +920,7 @@
 				PRODUCT_BUNDLE_IDENTIFIER = com.appculture.MissionControlTests;
 				PRODUCT_NAME = "$(TARGET_NAME)";
 				SWIFT_OPTIMIZATION_LEVEL = "-Owholemodule";
-				SWIFT_VERSION = 3.0;
+				SWIFT_VERSION = 5.0;
 			};
 			name = Release;
 		};

Tests/MissionControlTests.swift

@@ -241,7 +241,7 @@ class MissionControlTests: XCTestCase, MissionControlDelegate {
     func confirmRemoteConfigStateAfterNotification(_ notification: String) {
         confirmDidRefreshConfigDelegateCallback()
 
-        let _ = expectation(forNotification: notification, object: nil) { (notification) -> Bool in
+        let _ = expectation(forNotification: NSNotification.Name(rawValue: notification), object: nil) { (notification) -> Bool in
             self.confirmRemoteConfigState()
             return true
         }
@@ -378,7 +378,7 @@ class MissionControlTests: XCTestCase, MissionControlDelegate {
         MissionControl.launch(remoteConfigURL: URL.RemoteTestConfig)
 
         let notification = MissionControl.Notification.DidRefreshConfig
-        let _ = expectation(forNotification: notification, object: nil) { (notification) -> Bool in
+        let _ = expectation(forNotification: NSNotification.Name(rawValue: notification), object: nil) { (notification) -> Bool in
             ACMissionControl.shared.resetRemote()
             self.confirmCachedConfigState()
             return true
@@ -446,7 +446,7 @@ class MissionControlTests: XCTestCase, MissionControlDelegate {
         confirmDidFailRefreshingConfigDelegateCallback()
 
         let notification = MissionControl.Notification.DidFailRefreshingConfig
-        let _ = expectation(forNotification: notification, object: nil) { (notification) -> Bool in
+        let _ = expectation(forNotification: NSNotification.Name(rawValue: notification), object: nil) { (notification) -> Bool in
             guard let errorInfo = notification.userInfo?["Error"] as? String else { return false }
             XCTAssertEqual("\(errorInfo)", "\(error)", message)
             self.confirmInitialState()