Validator migrations

[karilint]

For future validator migrations, verify full-object validation uses validateFields(...) rather than iterating only over Object.keys(editData).

[karilint]

Starting implementation. I’ll audit the remaining full-object validation paths that iterate over editData fields and update them to use the shared validateFields(...) helper where appropriate, with focused frontend validator tests if behavior changes.

[karilint]

Manual test checklist:

• Open a new Reference form and leave required configured fields empty.
• Confirm the save/write action reports required validation errors even for untouched/missing fields such as primary date or authors when the selected reference type requires them.
• Open a staging flow that adds a new Reference from the dialog.
• Confirm the dialog blocks save when required Reference fields are missing and saves normally after valid Reference data is entered.

[karilint]

Implemented in draft PR #1182.

Possible root cause: some full-form validation paths still iterated over keys present in editData, so sparse edit objects could skip validators configured for missing fields. This PR adds a Reference full-field validator backed by validateFields(...) and wires it through DetailView/Reference validation paths.

[karilint]

Scope update: broadened the validation migration beyond Reference. Detail save/write validation now uses full-field validators for Reference, TimeBound, TimeUnit, Person, Museum, Region, Locality, and Species, so required validators still run when editData only contains changed fields.

Manual test checklist:

• Open each affected entity create/edit view and try saving with a required field omitted; the save should be blocked with the field validation message.
• Edit only one non-required field on an entity whose required fields are empty or invalid; the full-form validation should still catch the required/invalid field.
• For Species, verify taxonomy rules and mesowear numeric ranges still show the same messages as before.
• For TimeUnit, verify selecting "No value" for Rank saves rank as null.

Validated locally with frontend TypeScript, frontend lint, focused validator/component Jest suites, the legacy TimeUnit form Jest file, and the commit hook lint/tsc checks.

[karilint]

Fixed the TimeUnit e2e disabled write-button failures on the PR branch.

Root cause: full-form validation stored errors under display labels (for example "Upper Bound"), while per-field validation cleared errors by field keys (for example up_bound). For TimeUnit bound selection there was an additional mismatch between helper ids (up_bnd / low_bnd) and validator fields (up_bound / low_bound), so stale required errors could keep the Write button disabled after valid selections.

What changed:

• Preserve the validator field key on validation objects and use it when populating full-form errors.
• Use up_bound / low_bound consistently for TimeUnit bound validation error state.
• Avoid Cypress session validation depending on the slow dashboard load; validate the restored localStorage session instead.
• Let cy.resetDatabase() use the configured DB wait timeout for slower isolated local resets.

Manual test checklist:

• Create a TimeUnit with selected sequence, upper bound, lower bound, and reference; save succeeds.
• Create a TimeUnit without bounds; required bound errors keep Write disabled.
• Create/edit TimeUnit with invalid bound ordering; save remains blocked.
• Delete an unlinked TimeUnit.

Local validation:

• npm run tsc:frontend
• npm run test -- --runTestsByPath src/tests/shared/validators/validator.test.ts src/tests/shared/validators/reference.test.ts src/tests/components/StagingView.test.tsx --runInBand
• npm run lint:cypress
• npm run lint:frontend
• commit hook: npm run lint and npm run tsc
• isolated Cypress run: cypress/e2e/timeUnit.cy.js passed, 12/12

[karilint]

Follow-up fix pushed for Region create/delete e2e failures.

Root cause: the full-field validator now correctly checks configured fields, which exposed that Region marked reg_coord_id as required even during creation. New regions do not have reg_coord_id until the backend creates them, so the hidden id error kept the Write button disabled after entering a valid region name.

What changed:

• reg_coord_id validation only runs when the field exists on the edited Region data.
• Updated the validator unit expectation so new Region validation requires region, not a pre-existing id.

Validation:

• npm run tsc:frontend
• npm run test -- --runTestsByPath src/tests/shared/validators/validator.test.ts --runInBand
• npm run lint:frontend
• commit hook: full npm run lint and npm run tsc
• isolated Cypress: Region create passed; delete.spec.ts passed 3/3. The full local region.cy.js still showed two pre-existing edit-flow content wait flakes after successful GET /region/1, separate from the disabled Write button regression.