Skip to content

Commit 75aa359

Browse files
committed
Add more type hints
1 parent 82073c4 commit 75aa359

6 files changed

Lines changed: 143 additions & 70 deletions

File tree

phpstan-baseline.neon

Lines changed: 110 additions & 37 deletions
Large diffs are not rendered by default.

src/DependencyInjection/NucleosUserAdminExtension.php

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,6 @@
1414
use Nucleos\UserAdminBundle\Controller\UserCRUDController;
1515
use Nucleos\UserAdminBundle\Twig\AvatarRuntime;
1616
use Nucleos\UserAdminBundle\Twig\ImpersonateRuntime;
17-
use RuntimeException;
1817
use Symfony\Component\Config\Definition\Processor;
1918
use Symfony\Component\Config\FileLocator;
2019
use Symfony\Component\DependencyInjection\ContainerBuilder;
@@ -91,9 +90,6 @@ private function configureAvatar(array $config, ContainerBuilder $container): vo
9190
$container->setParameter('nucleos_user_admin.default_avatar', $config['avatar']['default_avatar']);
9291
}
9392

94-
/**
95-
* @throws RuntimeException
96-
*/
9793
private function fixImpersonating(array $config): array
9894
{
9995
if (!isset($config['impersonating']['parameters'])) {

src/Form/Type/RolesMatrixType.php

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -17,6 +17,9 @@
1717
use Symfony\Component\OptionsResolver\Options;
1818
use Symfony\Component\OptionsResolver\OptionsResolver;
1919

20+
/**
21+
* @extends AbstractType<mixed>
22+
*/
2023
final class RolesMatrixType extends AbstractType
2124
{
2225
private ExpandableRolesBuilderInterface $rolesBuilder;

src/Form/Type/SecurityRolesType.php

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -23,6 +23,9 @@
2323
use Symfony\Component\OptionsResolver\Options;
2424
use Symfony\Component\OptionsResolver\OptionsResolver;
2525

26+
/**
27+
* @extends AbstractType<mixed>
28+
*/
2629
final class SecurityRolesType extends AbstractType
2730
{
2831
protected EditableRolesBuilderInterface $rolesBuilder;

tests/DependencyInjection/NucleosUserAdminExtensionTest.php

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -162,11 +162,9 @@ private function createContainerBuilder(): ContainerBuilder
162162
->disableOriginalConstructor()
163163
;
164164

165-
// @phpstan-ignore-next-line
166165
if (!method_exists(ContainerBuilder::class, 'hasExtension')) {
167166
$mockBuilder->addMethods(['hasExtension']);
168167
}
169-
// @phpstan-ignore-next-line
170168
if (!method_exists(ContainerBuilder::class, 'prependExtensionConfig')) {
171169
$mockBuilder->addMethods(['prependExtensionConfig']);
172170
}
@@ -181,11 +179,9 @@ private function createTwigExtension(): TwigExtension
181179
{
182180
$mockBuilder = $this->getMockBuilder(TwigExtension::class);
183181

184-
// @phpstan-ignore-next-line
185182
if (!method_exists(TwigExtension::class, 'load')) {
186183
$mockBuilder = $mockBuilder->addMethods(['load']);
187184
}
188-
// @phpstan-ignore-next-line
189185
if (!method_exists(TwigExtension::class, 'getAlias')) {
190186
$mockBuilder = $mockBuilder->addMethods(['getAlias']);
191187
}

vendor-bin/tools/composer.lock

Lines changed: 27 additions & 25 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)