learned to allow and disallow space ssh access

Author: patrickcrocker

CHANGELOG.md

@@ -5,11 +5,12 @@ All notable changes to this project will be documented in this file.
 The format is based on [Keep a Changelog](http://keepachangelog.com/en/1.0.0/)
 and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.html).
 
-## 2.26.1 - Unreleased
+## 2.27.0 - Unreleased
 
 ### Added
 
 - Added `create-shared-domain` and `delete-shared-domain` commands
+- Added `allow-space-ssh` and `disallow-space-ssh`, thanks to a PR by [wanddynosios](https://github.com/wanddynosios)
 
 ### Changed
 

README.md

@@ -229,6 +229,40 @@ Delete a space
     space: myspace
 ```
 
+### `allow-space-ssh`
+
+Allow SSH access for the space
+
+| Params             | Usage      | CLI Version | Description
+| ---                | ---        | ---         | ---
+| `org`              | *Required* | All         | The organization to target (*Optional if set in the source config*)
+| `space`            | *Required* | All         | The space to allow SSH access (*Optional if set in the source config*)
+
+```yaml
+- put: cloud-foundry
+  params:
+    command: allow-space-ssh
+    org: myorg
+    space: myspace
+```
+
+### `disallow-space-ssh`
+
+Disallow SSH access for the space
+
+| Params             | Usage      | CLI Version | Description
+| ---                | ---        | ---         | ---
+| `org`              | *Required* | All         | The organization to target (*Optional if set in the source config*)
+| `space`            | *Required* | All         | The space to disallow SSH access (*Optional if set in the source config*)
+
+```yaml
+- put: cloud-foundry
+  params:
+    command: disallow-space-ssh
+    org: myorg
+    space: myspace
+```
+
 ### `create-private-domain`
 
 Create a private domain for a specific org

resource/commands/allow-space-ssh.sh

@@ -1,7 +1,5 @@
 
-space=$(get_option '.space')
-
 logger::info "Executing $(logger::highlight "$command"): $space"
 
 cf::target "$org" "$space"
-cf::cf allow-space-ssh "$space"
+cf::cf allow-space-ssh "$space"

resource/commands/disallow-space-ssh.sh

@@ -1,7 +1,5 @@
 
-space=$(get_option '.space')
-
 logger::info "Executing $(logger::highlight "$command"): $space"
 
 cf::target "$org" "$space"
-cf::cf disallow-space-ssh "$space"
+cf::cf disallow-space-ssh "$space"

spec/spec_helper.sh

@@ -754,4 +754,25 @@ EOF
 
     return $status
   }
+
+  test::is_space_ssh_allowed() {
+    local org=${1:-}
+    local space=${2:-}
+
+    [ -z "${org}" ] && error_and_exit "${FUNCNAME[0]} - org null or not set"
+    [ -z "${space}" ] && error_and_exit "${FUNCNAME[0]} - space null or not set"
+
+    quiet cf::target "$org" "$space"
+
+    local output status
+    if ! output=$(cf::cf space-ssh-allowed "$space"); then
+      status=${PIPESTATUS[0]}
+      logger::error "$output"
+      return $status
+    fi
+
+    test::untarget
+
+    [[ "$output" == *"ssh support is enabled"* ]]
+  }
 }

spec/ssh/allow-disallow-space-ssh_spec.sh

@@ -0,0 +1,60 @@
+#!/usr/bin/env shellspec
+
+set -euo pipefail
+
+Describe 'ssh'
+
+  setup() {
+    org=$(generate_test_name_with_spaces)
+    space=$(generate_test_name_with_spaces)
+
+    source=$(get_source_config "$org" "$space") || error_and_exit "[ERROR] error loading source json config"
+
+    test::login
+    test::create_org_and_space "$org" "$space"
+  }
+
+  teardown() {
+    test::delete_org_and_space "$org" "$space"
+    test::logout
+  }
+
+  BeforeAll 'setup'
+  AfterAll 'teardown'
+
+  It 'can disallow space ssh'
+    disallow_space_ssh() {
+      local config=$(
+        %text:expand
+        #|$source
+        #|params:
+        #|  command: disallow-space-ssh
+        #|  space: $space
+      )
+      put "$config"
+    }
+    When call disallow_space_ssh
+    The status should be success
+    The output should json '.version | keys == ["timestamp"]'
+    The error should include "Disabling ssh support for space '$space'"
+    Assert not test::is_space_ssh_allowed "$org" "$space"
+  End
+
+  It 'can allow space ssh'
+    allow_space_ssh() {
+      local config=$(
+        %text:expand
+        #|$source
+        #|params:
+        #|  command: allow-space-ssh
+        #|  space: $space
+      )
+      put "$config"
+    }
+    When call allow_space_ssh
+    The status should be success
+    The output should json '.version | keys == ["timestamp"]'
+    The error should include "Enabling ssh support for space '$space'"
+    Assert test::is_space_ssh_allowed "$org" "$space"
+  End
+End