Merge pull request #615 from oasisprotocol/uniyalabhishek/rofl/warn-user-rent-refund-policy

feat: add warning for user about refund policy

Author: uniyalabhishek

cmd/rofl/common/policy.go

@@ -0,0 +1,11 @@
+package common
+
+import "fmt"
+
+// RentRefundWarning is a standardized message shown before renting, topping up, or canceling a machine.
+const RentRefundWarning = "WARNING: Machine rental is non-refundable. You will not get a refund for the already paid term if you cancel."
+
+// PrintRentRefundWarning prints the standardized, user-facing refund policy warning.
+func PrintRentRefundWarning() {
+	fmt.Println(RentRefundWarning)
+}

cmd/rofl/deploy.go

@@ -195,6 +195,8 @@ var (
 				fmt.Printf("Selected per-%s pricing term, total price is ", term2str(term))
 				tp.PrettyPrint(ctx, "", os.Stdout)
 				fmt.Println(".")
+				// Warn the user about the non-refundable rental policy before first renting.
+				roflCommon.PrintRentRefundWarning()
 
 				// Prepare transaction.
 				tx := roflmarket.NewInstanceCreateTx(nil, &roflmarket.InstanceCreate{

cmd/rofl/machine/mgmt.go

@@ -85,6 +85,7 @@ var (
 			fmt.Printf("Using provider:     %s (%s)\n", machine.Provider, providerAddr)
 			fmt.Printf("Canceling machine:  %s [%s]\n", machineName, machine.ID)
 			fmt.Printf("WARNING: Canceling a machine will permanently destroy it including any persistent storage!\n")
+			roflCommon.PrintRentRefundWarning()
 
 			// Prepare transaction.
 			tx := roflmarket.NewInstanceCancelTx(nil, &roflmarket.InstanceCancel{
@@ -229,6 +230,7 @@ var (
 			fmt.Printf("Using provider:     %s (%s)\n", machine.Provider, providerAddr)
 			fmt.Printf("Top-up machine:     %s [%s]\n", machineName, machine.ID)
 			fmt.Printf("Top-up term:        %d x %s\n", roflCommon.TermCount, roflCommon.Term)
+			roflCommon.PrintRentRefundWarning()
 
 			// Prepare transaction.
 			tx := roflmarket.NewInstanceTopUpTx(nil, &roflmarket.InstanceTopUp{

docs/rofl.md

@@ -299,6 +299,13 @@ To start it back again, use [`oasis rofl machine restart`].
 To cancel the rental and permanently remove a machine,
 including its persistent storage, use `oasis rofl machine remove`.
 
+:::info
+
+Canceling a machine rental will not refund any payment for the already paid
+term.
+
+:::
+
 ## Advanced
 
 ### Upgrade ROFL app dependencies {#upgrade}

examples/rofl/deploy.out.static

@@ -2,6 +2,7 @@ Using provider: oasis1qzc8pldvm8vm3duvdrj63wgvkw34y9ucfcxzetqr
 Pushing ROFL app to OCI repository 'rofl.sh/7aaddbd5-d782-430f-9362-f0107aa109d2:1750242297'...
 No pre-existing machine configured, creating a new one...
 Taking offer: small [0000000000000000]
+WARNING: Machine rental is non-refundable. You will not get a refund for the already paid term if you cancel.
 Unlock your account.
 ? Passphrase: 
 You are about to sign the following transaction:

examples/rofl/machine-remove.in.static

@@ -0,0 +1 @@
+oasis rofl machine remove

examples/rofl/machine-remove.out.static

@@ -0,0 +1,33 @@
+Using provider:     oasis1qzc8pldvm8vm3duvdrj63wgvkw34y9ucfcxzetqr (oasis1qzc8pldvm8vm3duvdrj63wgvkw34y9ucfcxzetqr)
+Canceling machine:  default [0000000000000000]
+WARNING: Canceling a machine will permanently destroy it including any persistent storage!
+WARNING: Machine rental is non-refundable. You will not get a refund for the already paid term if you cancel.
+Unlock your account.
+? Passphrase:
+You are about to sign the following transaction:
+Format: plain
+Method: roflmarket.InstanceCancel
+Body:
+  {
+    "provider": "oasis1qzc8pldvm8vm3duvdrj63wgvkw34y9ucfcxzetqr",
+    "id": "0000000000000000"
+  }
+Authorized signer(s):
+  1. Amc63/tU+uNrYi7OID2a5a/hHbsbGTtAolnlyA+MF5g5 (secp256k1eth)
+     Nonce: 7
+Fee:
+  Amount: 0.0009876 ROSE
+  Gas limit: 9876
+  (gas price: 0.0000001 ROSE per gas unit)
+
+Network:  mainnet
+ParaTime: sapphire
+Account:  test:dave
+? Sign this transaction? Yes
+(In case you are using a hardware-based signer you may need to confirm on device.)
+Broadcasting transaction...
+Transaction included in block successfully.
+Round:            9356524
+Transaction hash: 4c619736c5678486950f5b5950a7f9b7c43b9656935cc472a90680187469f4dd
+Execution successful.
+Machine removed.

examples/rofl/machine-top-up.out.static

@@ -1,6 +1,7 @@
 Using provider:     oasis1qp2ens0hsp7gh23wajxa4hpetkdek3swyyulyrmz (oasis1qp2ens0hsp7gh23wajxa4hpetkdek3swyyulyrmz)
 Top-up machine:     default [000000000000022a]
 Top-up term:        12 x hour
+WARNING: Machine rental is non-refundable. You will not get a refund for the already paid term if you cancel.
 Unlock your account.
 ? Passphrase: 
 You are about to sign the following transaction: